From: "Yao, Lei A" <lei.a.yao@intel.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"yliu@fridaylinux.org" <yliu@fridaylinux.org>
Cc: "mst@redhat.com" <mst@redhat.com>
Subject: Re: [dpdk-dev] [PATCH] vhost: postpone ring addresses translations at kick time only
Date: Mon, 6 Nov 2017 03:26:04 +0000 [thread overview]
Message-ID: <2DBBFF226F7CF64BAFCA79B681719D953A2CFC88@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1d70c3b9-67c5-22d8-9312-33e43db0ac70@redhat.com>
Hi, Maxime
> -----Original Message-----
> From: Maxime Coquelin [mailto:maxime.coquelin@redhat.com]
> Sent: Friday, November 3, 2017 11:57 PM
> To: dev@dpdk.org; yliu@fridaylinux.org; Yao, Lei A <lei.a.yao@intel.com>
> Cc: mst@redhat.com
> Subject: Re: [PATCH] vhost: postpone ring addresses translations at kick time
> only
>
> Hi Lei,
>
> On 11/03/2017 04:52 PM, Maxime Coquelin wrote:
> > If multiple queue pairs are created but all are not used, the
> > device is never started, as unused queues aren't enabled and
> > their ring addresses aren't translated. The device is changed
> > to running state when all rings addresses are translated.
> >
> > This patch fixes this by postponning rings addresses translation
> > at kick time unconditionnaly, VHOST_USER_F_PROTOCOL_FEATURES
> > being negotiated or not.
> >
> > Reported-by: Lei Yao<lei.a.yao@intel.com>
> > Signed-off-by: Maxime Coquelin<maxime.coquelin@redhat.com>
> > ---
> > lib/librte_vhost/vhost_user.c | 33 ++++++++-------------------------
> > 1 file changed, 8 insertions(+), 25 deletions(-)
>
> Could you confirm the patch fixes the issue on your side?
>
> I tested below cases with and without IOMMU:
> - Host DPDK queues = 1 / QEMU queues = 1 / Guest DPDK queues = 1
> - Host DPDK queues = 2 / QEMU queues = 2 / Guest DPDK queues = 1
> - Host DPDK queues = 2 / QEMU queues = 2 / Guest DPDK queues = 2
>
> Thanks,
> Maxime
Thanks for your patch. I test my test cases with your patch based on v17.11-rc2,
It can fix my issue here.
BRs
Lei
next prev parent reply other threads:[~2017-11-06 3:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-03 15:52 Maxime Coquelin
2017-11-03 15:56 ` Maxime Coquelin
2017-11-06 3:26 ` Yao, Lei A [this message]
2017-11-06 8:12 ` Maxime Coquelin
2017-11-06 11:58 ` Yuanhan Liu
2017-11-07 1:28 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2DBBFF226F7CF64BAFCA79B681719D953A2CFC88@shsmsx102.ccr.corp.intel.com \
--to=lei.a.yao@intel.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=mst@redhat.com \
--cc=yliu@fridaylinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).