From: "Yao, Lei A" <lei.a.yao@intel.com>
To: Andy Green <andy@warmcat.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v5 03/16] bus/pci: replace strncpy dangerous code
Date: Tue, 15 May 2018 08:18:35 +0000 [thread overview]
Message-ID: <2DBBFF226F7CF64BAFCA79B681719D953A449AA3@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <24ddc6ec-87cf-5955-8fb8-dac4a268ac5b@warmcat.com>
> -----Original Message-----
> From: Andy Green [mailto:andy@warmcat.com]
> Sent: Tuesday, May 15, 2018 3:33 PM
> To: Yao, Lei A <lei.a.yao@intel.com>; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v5 03/16] bus/pci: replace strncpy dangerous
> code
>
>
>
> On 05/15/2018 02:12 PM, Yao, Lei A wrote:
> > Hi, Andy
> >
> > This patch will break the vfio-pci driver on my server.
> > I can't launch NIC with vfio-pci using testpmd. Could you have
> > a check on this? Thanks a lot!
> >
> > My server info:
> > OS: Ubuntu 16.04 LTS
> > gcc: 5.4.0
> > kernel: 4.4.0
> > CPU: Intel(R) Xeon(R) CPU E5-2699 v4 @ 2.20GHz
> > NIC: Ethernet Controller X710 for 10GbE SFP+
> >
> > My Step:
> > 1. Bind NIC to vfio-pci driver
> > modprobe vfio-pci
> > dpdk-devbind.py -b vfio-pci [PCI address of NIC]
> >
> > 2. Launch testpmd;
> > ./x86_64-native-linuxapp-gcc/app/testpmd -c 0x03 -n 4 -- -i
>
> I don't have any nic to test with.
>
> But it doesn't matter the patch is indeed wrong... I just sent you and
> the list a fix on top of the incomplete patch. "bus/pci: correct the
> earlier strlcpy conversion"
>
> Sorry...
>
> -Andy
>
Hi, Andy
Thanks a lot for your quick fix. It can work on my server now.
BRs
Lei
> >> -----Original Message-----
> >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Andy Green
> >> Sent: Saturday, May 12, 2018 9:48 AM
> >> To: dev@dpdk.org
> >> Subject: [dpdk-dev] [PATCH v5 03/16] bus/pci: replace strncpy dangerous
> >> code
> >>
> >> In function ‘pci_get_kernel_driver_by_path’,
> >> inlined from ‘pci_scan_one.isra.1’ at /home/agreen/projects/dpdk/
> >> drivers/bus/pci/linux/pci.c:317:8:
> >> /home/agreen/projects/dpdk/drivers/bus/pci/linux/pci.c:57:3: error:
> >> ‘strncpy’ specified bound depends on the length of the source argument
> >> [-Werror=stringop-overflow=]
> >> strncpy(dri_name, name + 1, strlen(name + 1) + 1);
> >>
> >> Signed-off-by: Andy Green <andy@warmcat.com>
> >> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> >> Fixes: d9a8cd9595f2 ("pci: add kernel driver type")
> >> Cc: stable@dpdk.org
> >> ---
> >> drivers/bus/pci/linux/pci.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/bus/pci/linux/pci.c b/drivers/bus/pci/linux/pci.c
> >> index 4630a8057..a73ee49c2 100644
> >> --- a/drivers/bus/pci/linux/pci.c
> >> +++ b/drivers/bus/pci/linux/pci.c
> >> @@ -54,7 +54,7 @@ pci_get_kernel_driver_by_path(const char
> *filename,
> >> char *dri_name)
> >>
> >> name = strrchr(path, '/');
> >> if (name) {
> >> - strncpy(dri_name, name + 1, strlen(name + 1) + 1);
> >> + strlcpy(dri_name, name + 1, sizeof(dri_name));
> >> return 0;
> >> }
> >>
> >
next prev parent reply other threads:[~2018-05-15 8:18 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-12 1:47 [dpdk-dev] [PATCH v5 00/16] Fix default build on gcc8.0.1 Andy Green
2018-05-12 1:47 ` [dpdk-dev] [PATCH v5 01/16] devtools/check-git: provide more generic grep pattern Andy Green
2018-05-12 1:47 ` [dpdk-dev] [PATCH v5 02/16] net/nfp: solve buffer overflow Andy Green
2018-05-12 1:47 ` [dpdk-dev] [PATCH v5 03/16] bus/pci: replace strncpy dangerous code Andy Green
2018-05-15 6:12 ` Yao, Lei A
2018-05-15 7:31 ` [dpdk-dev] [PATCH] bus/pci: correct the earlier strlcpy conversion Andy Green
2018-05-15 10:51 ` Andrew Rybchenko
2018-05-15 13:19 ` Thomas Monjalon
2018-05-15 7:32 ` [dpdk-dev] [PATCH v5 03/16] bus/pci: replace strncpy dangerous code Andy Green
2018-05-15 8:18 ` Yao, Lei A [this message]
2018-05-12 1:48 ` [dpdk-dev] [PATCH v5 04/16] bus/dpaa: solve inconsistent struct alignment Andy Green
2018-05-12 1:48 ` [dpdk-dev] [PATCH v5 05/16] net/axgbe: solve broken eeprom string comp Andy Green
2018-05-12 1:48 ` [dpdk-dev] [PATCH v5 06/16] net/nfp/nfpcore: solve strncpy misuse Andy Green
2018-05-12 1:48 ` [dpdk-dev] [PATCH v5 07/16] net/nfp/nfpcore: off-by-one and no NUL on strncpy use Andy Green
2018-05-12 1:48 ` [dpdk-dev] [PATCH v5 08/16] net/nfp: don't memcpy out of source range Andy Green
2018-05-12 1:48 ` [dpdk-dev] [PATCH v5 09/16] net/qede: strncpy length constant and NUL Andy Green
2018-05-12 1:48 ` [dpdk-dev] [PATCH v5 10/16] net/qede: solve broken strncpy Andy Green
2018-05-12 1:48 ` [dpdk-dev] [PATCH v5 11/16] net/sfc: make sure that copied stats name is NUL-terminated Andy Green
2018-05-12 1:48 ` [dpdk-dev] [PATCH v5 12/16] net/vdev_netvsc: readlink inputs cannot be aliased Andy Green
2018-05-13 7:20 ` Matan Azrad
2018-05-14 4:54 ` Andy Green
2018-05-12 1:48 ` [dpdk-dev] [PATCH v5 13/16] net/vdev_netvsc: 3 x strncpy misuse Andy Green
2018-05-13 7:47 ` Matan Azrad
2018-05-12 1:48 ` [dpdk-dev] [PATCH v5 14/16] app/proc-info: sprintf overrun bug Andy Green
2018-05-12 1:48 ` [dpdk-dev] [PATCH v5 15/16] app/test-bbdev: strcpy ok for allocated string Andy Green
2018-05-12 1:49 ` [dpdk-dev] [PATCH v5 16/16] " Andy Green
2018-05-14 4:59 ` [dpdk-dev] [PATCH v6 00/16] Fix default build on gcc8.0.1 Andy Green
2018-05-14 4:59 ` [dpdk-dev] [PATCH v6 01/16] devtools/check-git: provide more generic grep pattern Andy Green
2018-05-14 16:28 ` Ferruh Yigit
2018-05-14 5:00 ` [dpdk-dev] [PATCH v6 02/16] net/nfp: solve buffer overflow Andy Green
2018-05-14 5:00 ` [dpdk-dev] [PATCH v6 03/16] bus/pci: replace strncpy dangerous code Andy Green
2018-05-14 5:00 ` [dpdk-dev] [PATCH v6 04/16] bus/dpaa: solve inconsistent struct alignment Andy Green
2018-05-14 5:00 ` [dpdk-dev] [PATCH v6 05/16] net/axgbe: solve broken eeprom string comp Andy Green
2018-05-14 5:00 ` [dpdk-dev] [PATCH v6 06/16] net/nfp/nfpcore: solve strncpy misuse Andy Green
2018-05-14 5:00 ` [dpdk-dev] [PATCH v6 07/16] net/nfp/nfpcore: off-by-one and no NUL on strncpy use Andy Green
2018-05-14 5:00 ` [dpdk-dev] [PATCH v6 08/16] net/nfp: don't memcpy out of source range Andy Green
2018-05-14 5:00 ` [dpdk-dev] [PATCH v6 09/16] net/qede: strncpy length constant and NUL Andy Green
2018-05-14 20:16 ` Ferruh Yigit
2018-05-14 5:00 ` [dpdk-dev] [PATCH v6 10/16] net/qede: solve broken strncpy Andy Green
2018-05-14 20:20 ` Ferruh Yigit
2018-05-14 21:14 ` Ferruh Yigit
2018-05-14 23:04 ` Andy Green
2018-05-14 5:00 ` [dpdk-dev] [PATCH v6 11/16] net/sfc: make sure that copied stats name is NUL-terminated Andy Green
2018-05-14 5:00 ` [dpdk-dev] [PATCH v6 12/16] net/vdev_netvsc: readlink inputs cannot be aliased Andy Green
2018-05-14 5:00 ` [dpdk-dev] [PATCH v6 13/16] net/vdev_netvsc: convert snprintf to strlcpy Andy Green
2018-05-14 5:01 ` [dpdk-dev] [PATCH v6 14/16] app/proc-info: sprintf overrun bug Andy Green
2018-05-14 20:31 ` Ferruh Yigit
2018-05-14 5:01 ` [dpdk-dev] [PATCH v6 15/16] app/test-bbdev: strcpy ok for allocated string Andy Green
2018-05-14 20:42 ` Ferruh Yigit
2018-05-14 20:56 ` Ferruh Yigit
2018-05-14 21:01 ` Ferruh Yigit
2018-05-14 5:01 ` [dpdk-dev] [PATCH v6 16/16] " Andy Green
2018-05-14 21:03 ` Ferruh Yigit
2018-05-14 21:29 ` [dpdk-dev] [PATCH v6 00/16] Fix default build on gcc8.0.1 Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2DBBFF226F7CF64BAFCA79B681719D953A449AA3@SHSMSX101.ccr.corp.intel.com \
--to=lei.a.yao@intel.com \
--cc=andy@warmcat.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).