From: "Yan, Zhirun" <zhirun.yan@intel.com>
To: "Ye, Xiaolong" <xiaolong.ye@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>,
"Xing, Beilei" <beilei.xing@intel.com>
Subject: Re: [dpdk-dev] [PATCH v1] net/ixgbe: update PMD Tx offload mask
Date: Thu, 25 Oct 2018 07:02:24 +0000 [thread overview]
Message-ID: <2F9759EBFF61914290A3BA61BDBE2C860B9977E4@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <20181025060845.GB55104@intel.com>
> -----Original Message-----
> From: Ye, Xiaolong
> Sent: Thursday, October 25, 2018 2:09 PM
> To: Yan, Zhirun <zhirun.yan@intel.com>
> Cc: dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Xing, Beilei
> <beilei.xing@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v1] net/ixgbe: update PMD Tx offload mask
>
> On 10/25, Zhirun Yan wrote:
> >Tx offload mask is updated in following commit:
> >commit 1037ed842c37 ("mbuf: fix Tx offload mask") Currently, the new
> >added offload flags will be
>
> s/will be/are
Got it, I will modify in patch v2.
Thanks!
>
> Thanks,
> Xiaolong
>
> >not supported in PMD and application will fail to call PMD transmit
> >prepare function.
> >This patch updates IXGBE_TX_OFFFLOAD_MASK.
> >
> >Fixes: b161f72107 ("mbuf: remove too specific flags mask")
> >Signed-off-by: Zhirun Yan <zhirun.yan@intel.com>
> >---
> > drivers/net/ixgbe/ixgbe_rxtx.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> >diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c
> >b/drivers/net/ixgbe/ixgbe_rxtx.c index e6f61c900..d6e971440 100644
> >--- a/drivers/net/ixgbe/ixgbe_rxtx.c
> >+++ b/drivers/net/ixgbe/ixgbe_rxtx.c
> >@@ -58,6 +58,10 @@
> > #endif
> > /* Bit Mask to indicate what bits required for building TX context */
> > #define IXGBE_TX_OFFLOAD_MASK ( \
> >+ PKT_TX_OUTER_IPV6 | \
> >+ PKT_TX_OUTER_IPV4| \
> >+ PKT_TX_IPV6 | \
> >+ PKT_TX_IPV4 | \
> > PKT_TX_VLAN_PKT | \
> > PKT_TX_IP_CKSUM | \
> > PKT_TX_L4_MASK | \
> >--
> >2.17.1
> >
prev parent reply other threads:[~2018-10-25 7:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-25 13:42 Zhirun Yan
2018-10-25 6:08 ` Ye Xiaolong
2018-10-25 7:02 ` Yan, Zhirun [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2F9759EBFF61914290A3BA61BDBE2C860B9977E4@SHSMSX101.ccr.corp.intel.com \
--to=zhirun.yan@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).