From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, Stephen Hemminger <stephen@networkplumber.org>,
Chenbo Xia <chenbox@nvidia.com>
Subject: Re: [PATCH v2] vhost: make experimental API's stable
Date: Mon, 13 Nov 2023 10:53:56 +0100 [thread overview]
Message-ID: <2a0c3a5d-1ec5-47d6-a855-c456d6ce0410@redhat.com> (raw)
In-Reply-To: <CAJFAV8zTvPzueyb9CvOFw3SEN-52LY7vtA9XHDysKovCR4E6_A@mail.gmail.com>
On 11/13/23 10:52, David Marchand wrote:
> On Fri, Nov 10, 2023 at 9:52 AM Maxime Coquelin
> <maxime.coquelin@redhat.com> wrote:
>>
>> From: Stephen Hemminger <stephen@networkplumber.org>
>>
>> Transistion API's added from 2008 to 2022 to stable, except
>> Vhost-async's which are likely to require changes to be adopted.
>>
>> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>
> I have one comment below, but this can probably be fixed when applying.
>
> Reviewed-by: David Marchand <david.marchand@redhat.com>
>
>
>> diff --git a/lib/vhost/rte_vhost_crypto.h b/lib/vhost/rte_vhost_crypto.h
>> index 2b01ecda08..71a30ba202 100644
>> --- a/lib/vhost/rte_vhost_crypto.h
>> +++ b/lib/vhost/rte_vhost_crypto.h
>> @@ -40,7 +40,6 @@ enum rte_vhost_crypto_zero_copy {
>> * @return
>> * 0 on success, -1 on failure
>> */
>> -__rte_experimental
>> int
>> rte_vhost_crypto_driver_start(const char *path);
>>
>
> No need to include rte_compat.h in rte_vhost_crypto.h anymore: no
> symbol is marked internal or experimental after this change.
>
>
Ack, I will fix it while applying.
Thanks,
Maxime
next prev parent reply other threads:[~2023-11-13 9:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-10 8:52 Maxime Coquelin
2023-11-13 9:52 ` David Marchand
2023-11-13 9:53 ` Maxime Coquelin [this message]
2023-11-14 19:51 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a0c3a5d-1ec5-47d6-a855-c456d6ce0410@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=chenbox@nvidia.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).