From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Shahaf Shuler <shahafs@mellanox.com>, adrien.mazarguil@6wind.com
Cc: dev@dpdk.org, Elad Persiko <eladpe@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH v3] net/mlx5: support extended statistics
Date: Mon, 16 Jan 2017 16:18:41 +0000 [thread overview]
Message-ID: <2a106ecd-6a38-59fa-3f7c-7cd9c357ff3e@intel.com> (raw)
In-Reply-To: <1484573439-10752-1-git-send-email-shahafs@mellanox.com>
Hi Shahaf,
On 1/16/2017 1:30 PM, Shahaf Shuler wrote:
> Implement extended statistics callbacks.
>
> Suggested-by: Hanoch Haim <hhaim@cisco.com>
> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
> Signed-off-by: Elad Persiko <eladpe@mellanox.com>
I am getting following build error [1] with clang when MLX5_DEBUG=y,
this seems because of pedandic.
Variable length array supported by language with c99 but mlx is forcing
to compile itself with gnu99 (-std=gnu99), not sure why, which supports
variable length array as an extension.
[1]
.../drivers/net/mlx5/mlx5_stats.c:266:20: error: variable length array
folded to constant array as an extension [-Werror,-Wgnu-folding-constant]
uint64_t counters[xstats_n];
^~~~~~~~
.../drivers/net/mlx5/mlx5_stats.c:289:20: error: variable length array
folded to constant array as an extension [-Werror,-Wgnu-folding-constant]
uint64_t counters[xstats_n];
^~~~~~~~
next prev parent reply other threads:[~2017-01-16 16:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-16 13:30 Shahaf Shuler
2017-01-16 14:01 ` Adrien Mazarguil
2017-01-16 16:18 ` Ferruh Yigit [this message]
2017-01-17 14:29 ` [dpdk-dev] [PATCH] " Shahaf Shuler
2017-01-17 14:39 ` Shahaf Shuler
2017-01-17 14:37 ` [dpdk-dev] [PATCH v4] " Shahaf Shuler
2017-01-17 19:14 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a106ecd-6a38-59fa-3f7c-7cd9c357ff3e@intel.com \
--to=ferruh.yigit@intel.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=eladpe@mellanox.com \
--cc=shahafs@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).