From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Pengzhen Liu <liupengzhen3@huawei.com>, thomas@monjalon.net
Cc: dev@dpdk.org, Keith Wiles <keith.wiles@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/tap: fix invalid queue file descriptor
Date: Mon, 30 Oct 2017 15:55:48 -0700 [thread overview]
Message-ID: <2aeb75a6-7fcd-1d93-e424-7994e044a06b@intel.com> (raw)
In-Reply-To: <1509011493-26531-1-git-send-email-liupengzhen3@huawei.com>
On 10/26/2017 2:51 AM, Pengzhen Liu wrote:
> From: Keith Wiles <keith.wiles@intel.com>
>
> Rx and Tx queues share the common tap file descriptor, but save this
> value separately.
>
> Setting up Rx/Tx queue sets up both queues, release_queue close the
> tap file but update file descriptor only for that queue.
>
> This makes other queue's file descriptor invalid.
>
> As a workaround, prevent release_queue callback to be called by default.
>
> This is done by separating Rx/Tx setup functions, so that each only
> setup its own queue, this prevents rte_eth_rx/tx_queue_setup() calling
> release_queue before setup_queue.
>
> Fixes: 02f96a0a82d1 ("net/tap: add TUN/TAP device PMD")
>
> Signed-off-by: Keith Wiles <keith.wiles@intel.com>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Hi Pengzhen,
This is a commit from repo :) [1] from beginning of the year.
I assume this has been sent instead of another patch by mistake, please double
check if intended patch sent to mail list.
[1]
http://dpdk.org/commit/0002ca58
prev parent reply other threads:[~2017-10-30 22:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-26 9:51 Pengzhen Liu
2017-10-30 22:55 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2aeb75a6-7fcd-1d93-e424-7994e044a06b@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=keith.wiles@intel.com \
--cc=liupengzhen3@huawei.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).