DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Simei Su <simei.su@intel.com>,
	thomas@monjalon.net, andrew.rybchenko@oktetlabs.ru,
	kirill.rybalchenko@intel.com, qi.z.zhang@intel.com
Cc: dev@dpdk.org, wenjun1.wu@intel.com
Subject: Re: [PATCH 3/3] examples/ptpclient: add frequency adjustment support
Date: Mon, 18 Sep 2023 15:55:19 +0100	[thread overview]
Message-ID: <2c0e0312-a858-4913-890d-901b07c90b11@amd.com> (raw)
In-Reply-To: <20230809050700.271534-4-simei.su@intel.com>

On 8/9/2023 6:07 AM, Simei Su wrote:
> This patch applys PI servo algorithm to leverage frequency adjustment
> API to improve PTP timesync accuracy.
> 
> The command for starting ptpclient with PI algorithm is:
> ./build/examples/dpdk-ptpclient -a 0000:81:00.0 -c 1 -n 3 -- -T 0 -p 0x1
> --controller=pi
> 

Is there a sample application documentation to document new command line
argument and document logic to select which API to use, perhaps document
what is 'pi servo' algorithm is?

If there is no documentation, what do you think adding one?


  reply	other threads:[~2023-09-18 14:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-09  5:06 [PATCH 0/3] add frequency adjustment support for PTP timesync Simei Su
2023-08-09  5:06 ` [PATCH 1/3] ethdev: add frequency adjustment API Simei Su
2023-09-18 14:50   ` Ferruh Yigit
2023-09-28  6:19     ` Su, Simei
2023-08-09  5:06 ` [PATCH 2/3] examples/ptpclient: refine application Simei Su
2023-08-09  5:07 ` [PATCH 3/3] examples/ptpclient: add frequency adjustment support Simei Su
2023-09-18 14:55   ` Ferruh Yigit [this message]
2023-09-28  6:31     ` Su, Simei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2c0e0312-a858-4913-890d-901b07c90b11@amd.com \
    --to=ferruh.yigit@amd.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=dev@dpdk.org \
    --cc=kirill.rybalchenko@intel.com \
    --cc=qi.z.zhang@intel.com \
    --cc=simei.su@intel.com \
    --cc=thomas@monjalon.net \
    --cc=wenjun1.wu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).