From: Akhil Goyal <akhil.goyal@nxp.com>
To: Fan Zhang <roy.fan.zhang@intel.com>, dev@dpdk.org
Cc: pablo.de.lara.guarch@intel.com, jianjay.zhou@huawei.com, stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] crypto/virtio: fix iv physical address
Date: Thu, 14 Jun 2018 18:08:51 +0530 [thread overview]
Message-ID: <2f19ef2d-d132-7162-d1ef-78871a4b7752@nxp.com> (raw)
In-Reply-To: <20180614110257.10967-1-roy.fan.zhang@intel.com>
On 6/14/2018 4:32 PM, Fan Zhang wrote:
> The physical address of IV required by Virtio was computed using
> crypto operations' physical address plus the offset. However not
> all crypto ops will have physical address field initialized and
> compute it runtimely is costly. This patch fixes this problem by
> adding iv field in virtio_crypto_op_cookie and does a memcpy of
> iv instead.
>
> Fixes: 82adb12a1fce ("crypto/virtio: support burst enqueue/dequeue")
> Cc: stable@dpdk.org
>
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---
> drivers/crypto/virtio/virtio_cryptodev.c | 6 ++++++
> drivers/crypto/virtio/virtio_cryptodev.h | 3 +++
> drivers/crypto/virtio/virtio_rxtx.c | 8 +++++++-
> 3 files changed, 16 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/virtio/virtio_cryptodev.c b/drivers/crypto/virtio/virtio_cryptodev.c
> index df88953f6..6ffa7619c 100644
> --- a/drivers/crypto/virtio/virtio_cryptodev.c
> +++ b/drivers/crypto/virtio/virtio_cryptodev.c
> @@ -1223,6 +1223,12 @@ virtio_crypto_sym_pad_op_ctrl_req(
> /* Get cipher xform from crypto xform chain */
> cipher_xform = virtio_crypto_get_cipher_xform(xform);
> if (cipher_xform) {
> + if (cipher_xform->iv.length > VIRTIO_CRYPTO_MAX_IV_SIZE) {
> + VIRTIO_CRYPTO_SESSION_LOG_ERR(
> + "cipher IV cannot longer than %u",
> + VIRTIO_CRYPTO_MAX_IV_SIZE);
> + return -1;
> + }
> if (is_chainned)
> ret = virtio_crypto_sym_pad_cipher_param(
> &ctrl->u.sym_create_session.u.chain.para
> diff --git a/drivers/crypto/virtio/virtio_cryptodev.h b/drivers/crypto/virtio/virtio_cryptodev.h
> index e402c0309..676e008d9 100644
> --- a/drivers/crypto/virtio/virtio_cryptodev.h
> +++ b/drivers/crypto/virtio/virtio_cryptodev.h
> @@ -16,6 +16,8 @@
>
> #define NUM_ENTRY_VIRTIO_CRYPTO_OP 7
>
> +#define VIRTIO_CRYPTO_MAX_IV_SIZE 32
> +
max iv size supported in capability is 16 and here it is 32.
next prev parent reply other threads:[~2018-06-14 12:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-14 11:02 [dpdk-stable] " Fan Zhang
2018-06-14 12:38 ` Akhil Goyal [this message]
2018-06-15 4:45 ` [dpdk-stable] [dpdk-dev] " Zhoujian (jay)
2018-06-15 4:41 ` [dpdk-stable] " Zhoujian (jay)
2018-06-26 2:10 ` [dpdk-stable] [PATCH v2] " Fan Zhang
2018-07-03 12:29 ` Zhoujian (jay)
2018-07-05 10:53 ` De Lara Guarch, Pablo
2018-07-06 1:12 ` Zhoujian (jay)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f19ef2d-d132-7162-d1ef-78871a4b7752@nxp.com \
--to=akhil.goyal@nxp.com \
--cc=dev@dpdk.org \
--cc=jianjay.zhou@huawei.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=roy.fan.zhang@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).