From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Wenbo Cao <caowenbo@mucse.com>
Cc: dev@dpdk.org, thomas@monjalon.net, andrew.rybchenko@oktetlabs.ru,
yaojun@mucse.com
Subject: Re: [PATCH v6 7/8] net/rnp add devargs runtime parsing functions
Date: Tue, 5 Sep 2023 16:46:50 +0100 [thread overview]
Message-ID: <2fd454a8-fa2e-0acd-7f37-37bf87be7f5b@amd.com> (raw)
In-Reply-To: <20230901023050.40893-8-caowenbo@mucse.com>
On 9/1/2023 3:30 AM, Wenbo Cao wrote:
> add various runtime devargs command line options
> supported by this driver.
>
> Signed-off-by: Wenbo Cao <caowenbo@mucse.com>
<...>
>
> +#define RNP_HW_MAC_LOOPBACK_ARG "hw_loopback"
> +#define RNP_FW_UPDATE "fw_update"
> +#define RNP_RX_FUNC_SELECT "rx_func_sec"
> +#define RNP_TX_FUNC_SELECT "tx_func_sec"
> +#define RNP_FW_4X10G_10G_1G_DET "fw_4x10g_10g_1g_auto_det"
> +#define RNP_FW_FORCE_SPEED_1G "fw_force_1g_speed"
> +
Please document these runtime arguments in the device document.
Also please add 'RTE_PMD_REGISTER_PARAM_STRING()' macros to document
argument for pmdinfogen, please see samples in existing code.
<...>
> +
> +static int
> +rnp_parse_io_select_func(const char *key, const char *value, void *extra_args)
> +{
> + uint8_t select = RNP_IO_FUNC_USE_NONE;
> +
> + RTE_SET_USED(key);
> +
> + if (strcmp(value, "vec") == 0)
> + select = RNP_IO_FUNC_USE_VEC;
> + else if (strcmp(value, "simple") == 0)
> + select = RNP_IO_FUNC_USE_SIMPLE;
> + else if (strcmp(value, "common") == 0)
> + select = RNP_IO_FUNC_USE_COMMON;
> +
There is already an generic eal argument that lets you select between
vector and scalar datapath implementation:
--force-max-simd-bitwidth=<val>
<...>
> +static int rnp_post_handle(struct rnp_eth_adapter *adapter)
> +{
> + bool on = false;
> +
> + if (!adapter->eth_dev)
> + return -ENOMEM;
> + if (adapter->do_fw_update && adapter->fw_path) {
> + rnp_fw_update(adapter);
> + adapter->do_fw_update = 0;
This patch also enables FW upgrade, can you please detail this in the
commit log? Or even you can consider to split this part into separate patch.
next prev parent reply other threads:[~2023-09-05 15:46 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-01 2:30 [PATCH v6 0/8] [v6]drivers/net Add Support mucse N10 Pmd Driver Wenbo Cao
2023-09-01 2:30 ` [PATCH v6 1/8] net/rnp: add skeleton Wenbo Cao
2023-09-05 15:35 ` Ferruh Yigit
2023-09-06 8:15 ` 11
2024-03-29 11:28 ` Ferruh Yigit
2024-03-29 14:45 ` 11
2024-04-02 10:15 ` Ferruh Yigit
2023-09-01 2:30 ` [PATCH v6 2/8] net/rnp: add ethdev probe and remove Wenbo Cao
2023-09-05 15:36 ` Ferruh Yigit
2023-09-06 10:42 ` 11
2023-09-01 2:30 ` [PATCH v6 3/8] net/rnp: add device init and uninit Wenbo Cao
2023-09-05 15:44 ` Ferruh Yigit
2023-09-06 11:03 ` 11
2023-09-01 2:30 ` [PATCH v6 4/8] net/rnp: add mbx basic api feature Wenbo Cao
2023-09-05 15:45 ` Ferruh Yigit
2023-09-06 10:32 ` 11
2023-09-01 2:30 ` [PATCH v6 5/8] net/rnp add reset code for Chip Init process Wenbo Cao
2023-09-05 15:46 ` Ferruh Yigit
2023-09-06 9:23 ` 11
2023-09-01 2:30 ` [PATCH v6 6/8] net/rnp add port info resource init Wenbo Cao
2023-09-05 16:56 ` Ferruh Yigit
2023-09-06 9:07 ` 11
2023-09-01 2:30 ` [PATCH v6 7/8] net/rnp add devargs runtime parsing functions Wenbo Cao
2023-09-05 15:46 ` Ferruh Yigit [this message]
2023-09-06 9:13 ` 11
2023-09-01 2:30 ` [PATCH v6 8/8] net/rnp handle device interrupts Wenbo Cao
2023-09-05 15:34 ` [PATCH v6 0/8] [v6]drivers/net Add Support mucse N10 Pmd Driver Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2fd454a8-fa2e-0acd-7f37-37bf87be7f5b@amd.com \
--to=ferruh.yigit@amd.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=caowenbo@mucse.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
--cc=yaojun@mucse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).