DPDK patches and discussions
 help / color / mirror / Atom feed

From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Ajit Khaparde <ajit.khaparde@broadcom.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 3/4] bnxt: Add support for Async Link Notification
Date: Mon, 10 Oct 2016 16:40:17 +0100	[thread overview]
Message-ID: <30145fbb-2d02-de2d-e4b4-d1317645e2db@intel.com> (raw)
In-Reply-To: <20160929170356.GA52225@C02PT1RBG8WP.aus.broadcom.com>

Hi Ajit,

On 9/29/2016 6:03 PM, Ajit Khaparde wrote:
> This patch adds support to get Link notification asynchronously.
> The HW sends Async notifications on default completion ring. The
> PMD processes these notifications and logs a message appropriately.
> 
> Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> ---
>  drivers/net/bnxt/Makefile      |   1 +
>  drivers/net/bnxt/bnxt.h        |   6 +-
>  drivers/net/bnxt/bnxt_cpr.c    |  21 +++---
>  drivers/net/bnxt/bnxt_ethdev.c | 114 ++++++++++++++++++++++++++----
>  drivers/net/bnxt/bnxt_hwrm.c   |  93 ++++++++++++------------
>  drivers/net/bnxt/bnxt_irq.c    | 156 +++++++++++++++++++++++++++++++++++++++++
>  drivers/net/bnxt/bnxt_irq.h    |  51 ++++++++++++++
>  7 files changed, 367 insertions(+), 75 deletions(-)
>  create mode 100644 drivers/net/bnxt/bnxt_irq.c
>  create mode 100644 drivers/net/bnxt/bnxt_irq.h
> 

<...>

> +static inline int
> +rte_bnxt_atomic_read_link_status(struct rte_eth_dev *eth_dev,
> +				struct rte_eth_link *link)
> +{
> +	struct rte_eth_link *dst = link;
> +	struct rte_eth_link *src = &eth_dev->data->dev_link;
> +
> +	if (rte_atomic64_cmpset((uint64_t *)dst, *(uint64_t *)dst,
> +					*(uint64_t *)src) == 0)
> +		return 1;
> +
> +	return 0;
> +}
> +

This creates a compilation error:
.../drivers/net/bnxt/bnxt_ethdev.c:444:1:
error: unused function 'rte_bnxt_atomic_read_link_status'
[-Werror,-Wunused-function]
rte_bnxt_atomic_read_link_status(struct rte_eth_dev *eth_dev,
^

Since the patches in this patchet really not related, it is OK to send a
new version of just this patch.

Thanks,
ferruh

next prev parent reply	other threads:[~2016-10-10 15:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-29 17:03 Ajit Khaparde
2016-10-10 15:40 ` Ferruh Yigit [this message]
2016-10-11  1:22   ` Ajit Khaparde
2016-10-11 21:47   ` [dpdk-dev] [PATCH v2] " Ajit Khaparde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=30145fbb-2d02-de2d-e4b4-d1317645e2db@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=ajit.khaparde@broadcom.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).