From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Chao Zhu <chaozhu@linux.vnet.ibm.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v5 00/14] Patches for DPDK to support Power architecture
Date: Wed, 26 Nov 2014 21:57:31 +0100 [thread overview]
Message-ID: <3021970.lFMuY7bHMn@xps13> (raw)
In-Reply-To: <CALwxeUt+67TLtnWmf1QW85fT6D=7kcQ0S35MA-ai+=zvWUX47g@mail.gmail.com>
2014-11-26 10:32, David Marchand:
> On Tue, Nov 25, 2014 at 11:17 PM, Chao Zhu <chaozhu@linux.vnet.ibm.com>
> wrote:
>
> > The set of patches add IBM Power architecture to the DPDK. It adds the
> > required support to the EAL library. This set of patches doesn't support
> > full DPDK function on Power processors. To compile on PPC64 architecture,
> > GCC version >= 4.8 must be used. According to Bruce and Neil's comments,
> > this v5 patch removed the common configuration files of Powerpc in v4.
> > Also, it fixed the checkpatch issues in v3.
> >
> > The only unsolved checkpatch issue is :
> > ERROR: space prohibited before open square bracket '['
> >
> > This issue refers to the asm code input/output naming. But I think the
> > error is invalid.
> >
> >
> I must admit that the architecture abstraction in dpdk is not fully done,
> but it is more a "core" problem than a problem of this port itself.
> I am pretty sure that there is still a lot of places in dpdk that rely on
> the fact that they were written for x86 architecture.
>
> Neil's concerns on cpuflags (
> http://dpdk.org/ml/archives/dev/2014-November/008769.html) are valid but I
> think we could go with an incremental approach.
> Since Chao is commited to add power support to dpdk, we can have this fixed
> in subsequent patches with this patchset in 1.8.
>
>
> So, this patchset looks good enough to me.
> Acked-by: David Marchand <david.marchand@6wind.com>
Applied.
Nice to see a new architecture.
We'll have to make things more generic and do more tests but this is a good
first step.
Thanks
--
Thomas
prev parent reply other threads:[~2014-11-26 20:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-25 22:17 Chao Zhu
2014-11-25 22:17 ` [dpdk-dev] [PATCH v5 01/14] Add compiling definations for IBM " Chao Zhu
2014-11-25 22:17 ` [dpdk-dev] [PATCH v5 02/14] Add atomic operations " Chao Zhu
2014-11-25 22:17 ` [dpdk-dev] [PATCH v5 03/14] Add byte order " Chao Zhu
2014-11-25 22:17 ` [dpdk-dev] [PATCH v5 04/14] Add CPU cycle " Chao Zhu
2014-11-25 22:17 ` [dpdk-dev] [PATCH v5 05/14] Add prefetch operation " Chao Zhu
2014-11-25 22:17 ` [dpdk-dev] [PATCH v5 06/14] Add spinlock " Chao Zhu
2014-11-25 22:17 ` [dpdk-dev] [PATCH v5 07/14] Add vector memcpy " Chao Zhu
2014-11-25 22:17 ` [dpdk-dev] [PATCH v5 08/14] Add CPU flag checking " Chao Zhu
2014-11-25 22:17 ` [dpdk-dev] [PATCH v5 09/14] Remove iopl operation " Chao Zhu
2014-11-25 22:17 ` [dpdk-dev] [PATCH v5 10/14] Add cache size define for IBM Power Architecture Chao Zhu
2014-11-25 22:17 ` [dpdk-dev] [PATCH v5 11/14] Add huge page size define for IBM Power architecture Chao Zhu
2014-11-25 22:17 ` [dpdk-dev] [PATCH v5 12/14] Add eal memory support for IBM Power Architecture Chao Zhu
2014-11-25 22:17 ` [dpdk-dev] [PATCH v5 13/14] test_memzone:fix finding the second smallest segment Chao Zhu
2014-11-25 22:17 ` [dpdk-dev] [PATCH v5 14/14] Fix the compiling of test-pmd on IBM Power Architecture Chao Zhu
2014-11-26 9:32 ` [dpdk-dev] [PATCH v5 00/14] Patches for DPDK to support Power architecture David Marchand
2014-11-26 20:57 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3021970.lFMuY7bHMn@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=chaozhu@linux.vnet.ibm.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).