From: Thomas Monjalon <thomas@monjalon.net>
To: "Gaëtan Rivet" <gaetan.rivet@6wind.com>
Cc: dev@dpdk.org, wisamm@mellanox.com, stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] pci: fix parsing of address without function number
Date: Tue, 13 Nov 2018 18:00:17 +0100 [thread overview]
Message-ID: <3033024.8sQED2Sm3S@xps> (raw)
In-Reply-To: <20181112092905.g5vxszu5okxz4pzn@bidouze.vm.6wind.com>
12/11/2018 10:29, Gaëtan Rivet:
> On Mon, Nov 12, 2018 at 12:58:56AM +0100, Thomas Monjalon wrote:
> > If the last part of the PCI address (function number) is missing,
> > the parsing was successful, assuming function 0.
> > The call to strtoul is not returning an error in such a case,
> > so an explicit check is inserted before.
> >
> > This bug has always been there in older parsing macros:
> > - GET_PCIADDR_FIELD
> > - GET_BLACKLIST_FIELD
> >
>
> Returning 0, that's understandable, but errno not being set
> is rather lame from strtoul.
>
> > Fixes: af75078fece3 ("first public release")
> > Cc: stable@dpdk.org
> >
> > Reported-by: Wisam Jaddo <wisamm@mellanox.com>
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com>
Applied
prev parent reply other threads:[~2018-11-13 17:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-11 23:58 [dpdk-stable] " Thomas Monjalon
2018-11-12 9:29 ` Gaëtan Rivet
2018-11-13 17:00 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3033024.8sQED2Sm3S@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=gaetan.rivet@6wind.com \
--cc=stable@dpdk.org \
--cc=wisamm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).