From: Thomas Monjalon <thomas@monjalon.net>
To: Euan Bourke <euan.bourke@intel.com>
Cc: dev@dpdk.org, Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>
Subject: Re: [PATCH 1/2] doc: updated incorrect value for IP frag max fragments
Date: Wed, 20 Dec 2023 10:42:28 +0100 [thread overview]
Message-ID: <3037910.IobQ9Gjlxr@thomas> (raw)
In-Reply-To: <20231219151754.3285058-1-euan.bourke@intel.com>
19/12/2023 16:17, Euan Bourke:
> +Each table entry can hold information about packets of up to ``RTE_LIBRTE_IP_FRAG_MAX_FRAGS`` fragments,
> +where ``RTE_LIBRTE_IP_FRAG_MAX_FRAGS`` defaults to:
Instead of repeating the name, you can use "it".
> +
> +.. literalinclude:: ../../../config/rte_config.h
> + :start-after: /* ip_fragmentation defines */
> + :lines: 1
Relying on the comment before is a bit fragile here.
Please use "start-at".
next prev parent reply other threads:[~2023-12-20 9:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-19 15:17 Euan Bourke
2023-12-19 15:17 ` [PATCH 2/2] ip_frag: updated name for IP frag define Euan Bourke
2023-12-20 9:42 ` Thomas Monjalon [this message]
2023-12-20 10:03 ` [PATCH 1/2] doc: updated incorrect value for IP frag max fragments Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3037910.IobQ9Gjlxr@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=euan.bourke@intel.com \
--cc=konstantin.v.ananyev@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).