From: Thomas Monjalon <thomas@monjalon.net>
To: Arnon Warshavsky <arnon@qwilt.com>
Cc: bruce.richardson@intel.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] eal: register rte_panic user callback
Date: Wed, 07 Mar 2018 09:32:14 +0100 [thread overview]
Message-ID: <304114136.g7uiPYdxRp@xps> (raw)
In-Reply-To: <1520360928-9375-1-git-send-email-arnon@qwilt.com>
Hi,
06/03/2018 19:28, Arnon Warshavsky:
> The use case addressed here is dpdk environment init
> aborting the process due to panic,
> preventing the calling process from running its own tear-down actions.
Thank you for working on this long standing issue.
> A preferred, though ABI breaking solution would be
> to have the environment init always return a value
> rather than abort upon distress.
Yes, it is the preferred solution.
We should not use exit (panic & co) inside a library.
It is important enough to break the API.
I would be in favor of accepting such breakage in 18.05.
> This patch defines a couple of callback registration functions,
> one for panic and one for exit
> in case one wishes to distinguish between these events.
> Once a callback is set and panic takes place,
> it will be called prior to calling abort.
>
> Maiden voyage patch for Qwilt and myself.
Are you OK to visit the other side of the solution?
next prev parent reply other threads:[~2018-03-07 8:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-06 18:28 Arnon Warshavsky
2018-03-07 8:32 ` Thomas Monjalon [this message]
2018-03-07 8:57 ` Arnon Warshavsky
2018-03-07 9:05 ` Burakov, Anatoly
2018-03-07 9:59 ` Thomas Monjalon
2018-03-07 11:02 ` Arnon Warshavsky
2018-03-07 15:04 ` Thomas Monjalon
2018-03-07 16:26 ` Arnon Warshavsky
2018-03-07 11:29 ` Burakov, Anatoly
2018-03-07 13:23 ` Arnon Warshavsky
2018-03-07 15:06 ` Thomas Monjalon
2018-03-07 16:31 ` Arnon Warshavsky
2018-03-07 17:17 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=304114136.g7uiPYdxRp@xps \
--to=thomas@monjalon.net \
--cc=arnon@qwilt.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).