From: "Kulasek, TomaszX" <tomaszx.kulasek@intel.com>
To: Ravi Kerur <rkerur@gmail.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v1] Modify and modularize l3fwd code
Date: Tue, 2 Feb 2016 12:01:14 +0000 [thread overview]
Message-ID: <3042915272161B4EB253DA4D77EB373A14E44133@IRSMSX102.ger.corp.intel.com> (raw)
In-Reply-To: <1450739573-5915-1-git-send-email-rkerur@gmail.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ravi Kerur
> Sent: Tuesday, December 22, 2015 00:13
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH v1] Modify and modularize l3fwd code
>
> v1:
> > Rebase to latest code base for DPDK team review.
>
> Intel team's (Konstantin, Bruce and Declan) review comments
>
> v4<-v3:
> > Fix code review comments from Konstantin
> > Move buffer optimization code into l3fwd_lpm_sse.h
> and l3fwd_em_sse.h for LPM and EM respectively
> > Add compile time __SSE4_1__ for header file inclusion
> > Tested with CONFIG_RTE_MACHINE=default for non
> __SSE4_1__ compilation and build
> > Compiled for GCC 4.8.4 and 5.1 on Ubuntu 14.04
>
> v3<-v2:
> > Fix code review comments from Bruce
> > Fix multiple static definitions
> > Move local #defines to C files, common #defines
> to H file.
> > Rename ipv4_l3fwd_route to ipv4_l3fwd_lpm and ipv4_l3fwd_em
> > Rename ipv6_l3fwd_route to ipv6_l3fwd_lpm and ipv6_l3fwd_lpm
> > Pass additional parameter to send_single_packet
> > Compiled for GCC 4.8.4 and 5.1 on Ubuntu 14.04
>
> v2<-v1:
> > Fix errors in GCC 5.1
> > Restore "static inline" functions, rearrange
> functions to take "static inline" into account
> > Duplicate main_loop for LPM and EM
>
> v1:
> > Split main.c into following 3 files
> > main.c, (parsing, buffer alloc, and other utilities)
> > l3fwd_lpm.c, (Longest Prefix Match functions)
> > l3fwd_em.c, (Exact Match f.e. Hash functions)
> > l3fwd.h, (Common defines and prototypes)
>
> > Select LPM or EM based on run time selection f.e.
> > l3fwd -c 0x1 -n 1 -- -p 0x1 -E ... (Exact Match)
> > l3fwd -c 0x1 -n 1 -- -p 0x1 -L ... (LPM)
>
> > Options "E" and "L" are mutualy-exclusive.
>
> > Use function pointers during initialiation of relevant
> data structures.
>
> > Remove unwanted #ifdefs in the code with exception to
> > DO_RFC_1812_CHECKS
> > RTE_MACHINE_CPUFLAG_SSE4_2
>
> > Compiled for
> > i686-native-linuxapp-gcc
> > x86_64-native-linuxapp-gcc
> > x86_x32-native-linuxapp-gcc
> > x86_64-native-bsdapp-gcc
>
> > Tested on
> > Ubuntu 14.04 (GCC 4.8.4)
> > FreeBSD 10.0 (GCC 4.8)
> > I217 and I218 respectively.
>
> Signed-off-by: Ravi Kerur <rkerur@gmail.com>
> ---
Tested-by: Tomasz Kulasek <tomaszx.kulasek@intel.com>
Acked-by: Tomasz Kulasek <tomaszx.kulasek@intel.com>
next prev parent reply other threads:[~2016-02-02 12:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-21 23:11 Ravi Kerur
2015-12-21 23:12 ` Ravi Kerur
2016-01-18 13:30 ` Ananyev, Konstantin
2016-02-02 12:01 ` Kulasek, TomaszX [this message]
2016-02-04 21:55 ` Thomas Monjalon
2016-02-16 12:09 ` Azarewicz, PiotrX T
2016-02-16 13:04 ` Thomas Monjalon
2016-02-16 14:03 ` [dpdk-dev] [PATCH v2 1/1] examples/l3fwd: modify " Piotr Azarewicz
2016-02-18 9:08 ` [dpdk-dev] [PATCH v3 " Piotr Azarewicz
2016-02-24 13:16 ` Thomas Monjalon
2016-02-24 14:15 ` Azarewicz, PiotrX T
2016-02-25 10:24 ` [dpdk-dev] [PATCH v4 " Piotr Azarewicz
2016-02-28 20:50 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3042915272161B4EB253DA4D77EB373A14E44133@IRSMSX102.ger.corp.intel.com \
--to=tomaszx.kulasek@intel.com \
--cc=dev@dpdk.org \
--cc=rkerur@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).