From: Thomas Monjalon <thomas@monjalon.net>
To: "Laatz, Kevin" <kevin.laatz@intel.com>,
Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org,
Reshma Pattan <reshma.pattan@intel.com>,
Flavia Musatescu <flavia.musatescu@intel.com>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] telemetry: fix build
Date: Fri, 28 Jun 2019 11:17:06 +0200 [thread overview]
Message-ID: <3057664.AIUAmKyhIq@xps> (raw)
In-Reply-To: <114e7aba-06da-75b0-3459-7bac9c4119f1@intel.com>
28/06/2019 10:46, Laatz, Kevin:
>
> On 27/06/2019 20:51, Ferruh Yigit wrote:
> > Build error:
> > ../lib/librte_telemetry/rte_telemetry.c:558:28:
> > error: comparison of unsigned expression < 0 is always false
> > [-Werror,-Wtautological-compare]
> >
> > Build error not observed in default make build because telemetry library
> > disabled by default but easier to reproduce via meson.
No, I compile telemetry with make and with meson.
I cannot reproduce the error. I guess it depends of the compiler version?
> > Fixing by converting unsigned variables to signed.
> >
> > Fixes: 0fe3a37924d4 ("telemetry: format json response when sending stats")
> > Fixes: 4080e46c8078 ("telemetry: support global metrics")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > ---
> > Cc: Reshma Pattan <reshma.pattan@intel.com>
> > Cc: Flavia Musatescu <flavia.musatescu@intel.com>
> > ---
> > lib/librte_telemetry/rte_telemetry.c | 12 ++++++------
> > lib/librte_telemetry/rte_telemetry_internal.h | 6 +++---
> > 2 files changed, 9 insertions(+), 9 deletions(-)
>
> Acked-by: Kevin Laatz <kevin.laatz@intel.com>
Applied, thanks
next prev parent reply other threads:[~2019-06-28 9:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-27 19:51 [dpdk-stable] " Ferruh Yigit
2019-06-28 8:46 ` Laatz, Kevin
2019-06-28 9:17 ` Thomas Monjalon [this message]
2019-06-28 9:55 ` [dpdk-stable] [dpdk-dev] " Ferruh Yigit
2019-06-28 9:57 ` Thomas Monjalon
2019-06-28 10:28 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3057664.AIUAmKyhIq@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=flavia.musatescu@intel.com \
--cc=kevin.laatz@intel.com \
--cc=reshma.pattan@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).