From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Shahaf Shuler <shahafs@mellanox.com>,
Ferruh Yigit <ferruh.yigit@intel.com>,
"bernard.iremonger@intel.com" <bernard.iremonger@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "ailan@redhat.com" <ailan@redhat.com>,
"jan.scheurich@ericsson.com" <jan.scheurich@ericsson.com>,
"vkaplans@redhat.com" <vkaplans@redhat.com>,
"bruce.richardson@intel.com" <bruce.richardson@intel.com>,
Thomas Monjalon <thomas@monjalon.net>,
"konstantin.ananyev@intel.com" <konstantin.ananyev@intel.com>,
Jens Freimann <jfreimann@redhat.com>
Subject: Re: [dpdk-dev] [PATCH v4 1/2] testpmd: add forwarding mode to simulate a noisy neighbour
Date: Wed, 27 Jun 2018 16:09:02 +0200 [thread overview]
Message-ID: <308c794e-7aea-c848-5b4c-afeb825c9d21@redhat.com> (raw)
In-Reply-To: <DB7PR05MB4426DDCF5DCED8A1C97EE998C3480@DB7PR05MB4426.eurprd05.prod.outlook.com>
Hi Sharaf,
On 06/27/2018 03:51 PM, Shahaf Shuler wrote:
> Tuesday, June 26, 2018 4:39 PM, Ferruh Yigit:
>> Subject: Re: [dpdk-dev] [PATCH v4 1/2] testpmd: add forwarding mode to
>> simulate a noisy neighbour
>>
>> On 6/26/2018 1:17 PM, Shahaf Shuler wrote:
>>> HI Maxime, Jens
>>>
>>> Saturday, June 23, 2018 11:09 AM, Maxime Coquelin:
>>>> Subject: [dpdk-dev] [PATCH v4 1/2] testpmd: add forwarding mode to
>>>> simulate a noisy neighbour
>>>>
>>>> From: Jens Freimann <jfreimann@redhat.com>
>>>>
>>>> This adds a new forwarding mode to testpmd to simulate more realistic
>>>> behavior of a guest machine engaged in receiving and sending packets
>>>> performing Virtual Network Function (VNF).
>>>
>>> I really like the idea of adding application w/ more realistic behavior to the
>> DPDK tree in order to use them in the non-regression cycle.
>>>
>>> I am just wondering if putting it as another forward engine in testpmd is
>> the right place for it.
>>
>> Hi Shahaf,
>>
>> This was the request in old review comments. As you said it is good to have
>> more realistic behavior but also we would like to test/use io forwarding, so
>> new forwarding engine is way of having both two.
>
> Sorry, I missed reading the previous comments.
> As I said, there are upsides and downsides to it. I still think it deserve a separate example but we can start inside testpmd and move it to other location when needed.
I get your point, but I think it is better to have it in testpmd as we
intend to use it to gather some benchmarks.
And yes, if this is turn out to be problematic, we can move it outside
testpmd at some points.
Thanks for your insights,
Maxime
next prev parent reply other threads:[~2018-06-27 14:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-23 8:08 [dpdk-dev] [PATCH v4 0/2] testpmd: simulating noisy host environment Maxime Coquelin
2018-06-23 8:08 ` [dpdk-dev] [PATCH v4 1/2] testpmd: add forwarding mode to simulate a noisy neighbour Maxime Coquelin
2018-06-26 11:09 ` Iremonger, Bernard
2018-06-29 13:38 ` Maxime Coquelin
2018-06-29 14:05 ` Iremonger, Bernard
2018-06-29 14:24 ` Maxime Coquelin
2018-06-29 14:28 ` Thomas Monjalon
2018-06-26 12:17 ` Shahaf Shuler
2018-06-26 13:38 ` Ferruh Yigit
2018-06-27 13:51 ` Shahaf Shuler
2018-06-27 14:09 ` Maxime Coquelin [this message]
2018-06-29 14:23 ` Maxime Coquelin
2018-06-27 11:43 ` Kevin Traynor
2018-06-27 14:12 ` Adrien Mazarguil
2018-06-23 8:08 ` [dpdk-dev] [PATCH v4 2/2] testpmd: update testpmd doc to include noisy forwarding mode Maxime Coquelin
2018-06-26 11:12 ` Iremonger, Bernard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=308c794e-7aea-c848-5b4c-afeb825c9d21@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=ailan@redhat.com \
--cc=bernard.iremonger@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jan.scheurich@ericsson.com \
--cc=jfreimann@redhat.com \
--cc=konstantin.ananyev@intel.com \
--cc=shahafs@mellanox.com \
--cc=thomas@monjalon.net \
--cc=vkaplans@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).