DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Anatoly Burakov <anatoly.burakov@intel.com>
Cc: dev@dpdk.org, "Tan, Jianfeng" <jianfeng.tan@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2 5/5] eal: fix race condition in IPC requests
Date: Wed, 21 Mar 2018 09:51:07 +0100	[thread overview]
Message-ID: <31054417.J3CPfAh1aF@xps> (raw)
In-Reply-To: <f6c2f610-eba4-f579-3d4e-8e993e179be4@intel.com>

07/03/2018 15:06, Tan, Jianfeng:
> 
> On 3/2/2018 4:41 PM, Anatoly Burakov wrote:
> > Unlocking the action list before sending message and locking it
> > again aftterwards introduces a window where a response might
> 
> Typo: afterwards
> 
> > arrive before we have a chance to start waiting on a condition,
> > resulting in timeouts on valid messages.
> >
> > Fixes: 783b6e54971d ("eal: add synchronous multi-process communication")
> > Cc: jianfeng.tan@intel.com
> >
> > Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> 
> Acked-by: Jianfeng Tan <jianfeng.tan@intel.com>
> 
> Thank you for catching another bug :-)

Series applied, thanks

      reply	other threads:[~2018-03-21  8:51 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-22 15:43 [dpdk-dev] [PATCH 1/4] eal: fix IPC timeouts Anatoly Burakov
2018-02-22 15:43 ` [dpdk-dev] [PATCH 2/4] eal: fix IPC socket paths Anatoly Burakov
2018-02-23  3:14   ` Tan, Jianfeng
2018-02-22 15:44 ` [dpdk-dev] [PATCH 3/4] eal: fix IPC request " Anatoly Burakov
2018-02-23  3:15   ` Tan, Jianfeng
2018-02-22 15:44 ` [dpdk-dev] [PATCH 4/4] eal: fix handling of errno values in IPC Anatoly Burakov
2018-02-23  3:16   ` Tan, Jianfeng
2018-02-23  3:11 ` [dpdk-dev] [PATCH 1/4] eal: fix IPC timeouts Tan, Jianfeng
2018-03-02  8:41 ` [dpdk-dev] [PATCH v2 1/5] " Anatoly Burakov
2018-03-02  8:41 ` [dpdk-dev] [PATCH v2 2/5] eal: fix IPC socket paths Anatoly Burakov
2018-03-02  8:41 ` [dpdk-dev] [PATCH v2 3/5] eal: fix IPC request " Anatoly Burakov
2018-03-02  8:41 ` [dpdk-dev] [PATCH v2 4/5] eal: fix handling of errno values in IPC Anatoly Burakov
2018-03-02  8:41 ` [dpdk-dev] [PATCH v2 5/5] eal: fix race condition in IPC requests Anatoly Burakov
2018-03-07 14:06   ` Tan, Jianfeng
2018-03-21  8:51     ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=31054417.J3CPfAh1aF@xps \
    --to=thomas@monjalon.net \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=jianfeng.tan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).