From: Thomas Monjalon <thomas@monjalon.net>
To: Jakub Grajciar <jgrajcia@cisco.com>
Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>,
David Marchand <david.marchand@redhat.com>,
Anatoly Burakov <anatoly.burakov@intel.com>
Subject: Re: [dpdk-dev] [PATCH v6] net/memif: zero-copy slave
Date: Mon, 11 Nov 2019 16:24:47 +0100 [thread overview]
Message-ID: <3129101.eYSCb3BGBK@xps> (raw)
In-Reply-To: <ce978d55-a298-9380-9db7-81de04654e1d@intel.com>
11/11/2019 16:21, Ferruh Yigit:
> On 11/4/2019 11:03 AM, Jakub Grajciar wrote:
> > Zero-copy slave support for memif PMD.
> > Slave interface exposes DPDK memory to
> > master interface. Only single file segments
> > are supported (EAL option --single-file-segments).
> >
> > Signed-off-by: Jakub Grajciar <jgrajcia@cisco.com>
> > ---
> > doc/guides/nics/memif.rst | 42 +-
> > drivers/net/memif/Makefile | 1 +
> > drivers/net/memif/memif_socket.c | 65 +--
> > drivers/net/memif/meson.build | 1 +
> > drivers/net/memif/rte_eth_memif.c | 449 +++++++++++++++++-
> > drivers/net/memif/rte_eth_memif.h | 11 +-
> > lib/librte_eal/common/eal_common_mcfg.c | 7 +
> > .../common/include/rte_eal_memconfig.h | 13 +
> > lib/librte_eal/rte_eal_version.map | 1 +
> > 9 files changed, 516 insertions(+), 74 deletions(-)
>
> net/memif part looks good to me,
>
> @David, @Anatoly, any concern on new eal API, is it good to go?
I didn't get into details of this PMD,
but requesting an EAL property looks strange to me.
Is memif using directly some EAL memory?
Or is it using memory from mempool?
If it is from mempool, then the property should be requested to mempool.
Reminder: mempool memory is not always from EAL.
next prev parent reply other threads:[~2019-11-11 15:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-09 8:22 [dpdk-dev] [PATCH v4] " Jakub Grajciar
2019-07-10 15:06 ` Ferruh Yigit
2019-07-23 12:35 ` Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco)
2019-08-22 8:18 ` [dpdk-dev] [PATCH v5] " Jakub Grajciar
2019-10-04 13:23 ` Ferruh Yigit
2019-10-15 16:59 ` Ferruh Yigit
2019-10-17 11:52 ` Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco)
2019-10-17 16:04 ` Ferruh Yigit
2019-10-17 16:45 ` Ferruh Yigit
2019-10-21 16:07 ` Ferruh Yigit
2019-10-25 16:44 ` Yigit, Ferruh
2019-10-29 14:28 ` David Marchand
2019-10-30 10:17 ` Jakub Grajciar -X (jgrajcia - PANTHEON TECH SRO at Cisco)
2019-10-30 10:25 ` David Marchand
2019-11-04 11:03 ` [dpdk-dev] [PATCH v6] " Jakub Grajciar
2019-11-11 15:21 ` Ferruh Yigit
2019-11-11 15:24 ` Thomas Monjalon [this message]
2019-11-12 12:55 ` Jakub Grajciar -X (jgrajcia - PANTHEON TECH SRO at Cisco)
2019-11-11 15:49 ` David Marchand
2019-11-15 16:55 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3129101.eYSCb3BGBK@xps \
--to=thomas@monjalon.net \
--cc=anatoly.burakov@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jgrajcia@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).