From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Jiayu Hu <jiayu.hu@intel.com>, jingjing.wu@intel.com
Cc: dev@dpdk.org, konstantin.ananyev@intel.com, thomas@monjalon.net,
jianfeng.tan@intel.com, yliu@fridaylinux.org
Subject: Re: [dpdk-dev] [PATCH 1/2] app/testpmd: support the heavywight mode GRO
Date: Thu, 10 Aug 2017 10:50:02 +0100 [thread overview]
Message-ID: <31db58bb-220b-834b-ceb7-2bdf23b5659d@intel.com> (raw)
In-Reply-To: <1502333448-75976-2-git-send-email-jiayu.hu@intel.com>
On 8/10/2017 3:50 AM, Jiayu Hu wrote:
> The GRO library provides two reassembly modes: lightweight mode and
> heavyweight mode. This patch is to support the heavyweight mode in
> csum forwarding engine.
>
> With the command "gro (heavymode|lightmode) (on|off) <port id>", users
> can select the lightweight mode or the heavyweight mode to use. With
> the command "gro flush interval <num>", users can set the interval of
> flushing GROed packets from the reassembly tables for the heavyweight
> mode.
>
> Signed-off-by: Jiayu Hu <jiayu.hu@intel.com>
> ---
> app/test-pmd/cmdline.c | 79 ++++++++++++++++++++++++++++++++++++++++++++++---
> app/test-pmd/config.c | 33 +++++++++++++--------
> app/test-pmd/csumonly.c | 29 ++++++++++++++----
> app/test-pmd/testpmd.c | 17 +++++++++++
> app/test-pmd/testpmd.h | 12 +++++++-
> 5 files changed, 147 insertions(+), 23 deletions(-)
>
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
> index cd8c358..3224ce1 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -423,7 +423,7 @@ static void cmd_help_long_parsed(void *parsed_result,
> "tso show (portid)"
> " Display the status of TCP Segmentation Offload.\n\n"
>
> - "gro (on|off) (port_id)"
> + "gro (heavymode|lightmode) (on|off) (port_id)\n"
Not specific / limited to gro, but I have a few testpmd usability questions:
1) to update some settings, there are two root level commands already:
a) set ... (like: "set fwd mac", "set promisc #P on")
b) port config ... (like: "port config #P speed auto duplex auto")
I don't know what it difference between above two, but thinking as "port
config" is to configure ports and "set" is to set rest of testpmd config
makes sense to me. (but "set vf .." and "set port .." doesn't fit to
this statement)
Instead of adding "gro" root level command, why not add this under "port
config", like: "port config #P gro on" ? (or "set port #P gro on")
2) Should each configuration set have a corresponding show command?
How a user can see the current gro setting?
Do we need a "show port gro" ?
3) Where to place #P in the command:
There are inconsistencies about where to put it, like:
"port config #P l2-tunnel enable"
"port config mtu #P value"
"port #P rxq #Q start"
or
"show port info #P"
"show port #P rss-hash ip4 key"
It can be good to define a place for it for consistency.
4) Using "port" keyword in some commands before port_id:
Like: "set link-down port #P", "reset port #P mirror-rule value"
Mostly we don't have it:
"show txq info #P #Q", "set bonding mode #M #P", "set stat_qmap rx #P
#Q", "vlan set strip on #P"
It can be good to define one or other.
And I guess having need to use "port" keyword can be an indication that
command should move under "port" command:
"reset port #P mirror-rule #id" can be "port reset #P mirror-rule #id"
Thanks,
ferruh
next prev parent reply other threads:[~2017-08-10 9:56 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-10 2:50 [dpdk-dev] [PATCH 0/2] Support the Heavyweight Mode GRO in Testpmd Jiayu Hu
2017-08-10 2:50 ` [dpdk-dev] [PATCH 1/2] app/testpmd: support the heavywight mode GRO Jiayu Hu
2017-08-10 9:50 ` Ferruh Yigit [this message]
2017-08-15 6:01 ` Jiayu Hu
2017-08-10 2:50 ` [dpdk-dev] [PATCH 2/2] doc: update testpmd user guide for the heavyweight " Jiayu Hu
2017-08-17 9:08 ` [dpdk-dev] [PATCH v2 0/2] Support the Heavyweight Mode GRO in Testpmd Jiayu Hu
2017-08-17 9:08 ` [dpdk-dev] [PATCH v2 1/2] app/testpmd: support the heavywight mode GRO Jiayu Hu
2017-08-21 11:03 ` Ferruh Yigit
2017-08-22 1:00 ` Hu, Jiayu
[not found] ` <671112a6-6ac6-7476-4270-be1a0258f06e@intel.com>
2017-08-22 14:27 ` Jiayu Hu
2017-08-21 11:16 ` Ferruh Yigit
2017-08-22 0:53 ` Hu, Jiayu
2017-08-17 9:08 ` [dpdk-dev] [PATCH v2 2/2] doc: update testpmd user guide for the heavyweight " Jiayu Hu
2017-08-21 11:03 ` Ferruh Yigit
2017-08-22 0:52 ` Hu, Jiayu
2017-09-03 6:30 ` [dpdk-dev] [PATCH v3] app/testpmd: enable the heavyweight mode TCP/IPv4 GRO Jiayu Hu
2017-09-20 7:00 ` Yao, Lei A
2017-09-25 10:20 ` Hu, Jiayu
2017-09-26 3:54 ` Hu, Jiayu
2017-09-25 11:11 ` Ferruh Yigit
2017-09-26 6:26 ` [dpdk-dev] [PATCH v4] " Jiayu Hu
2017-09-27 7:23 ` Yao, Lei A
2017-10-06 23:04 ` Ferruh Yigit
2017-10-06 23:26 ` Ferruh Yigit
2017-10-07 0:51 ` Hu, Jiayu
2017-10-07 7:45 ` [dpdk-dev] [PATCH v5] " Jiayu Hu
2017-10-07 7:58 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31db58bb-220b-834b-ceb7-2bdf23b5659d@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=jianfeng.tan@intel.com \
--cc=jiayu.hu@intel.com \
--cc=jingjing.wu@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=thomas@monjalon.net \
--cc=yliu@fridaylinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).