From: Thomas Monjalon <thomas@monjalon.net>
To: Vipin Varghese <vipin.varghese@amd.com>,
Stephen Hemminger <stephen@networkplumber.org>
Cc: david.marchand@redhat.com, sivaprasad.tummala@amd.com, dev@dpdk.org
Subject: Re: [PATCH] usertools: enhance logic to display NUMA
Date: Tue, 11 Jul 2023 18:26:04 +0200 [thread overview]
Message-ID: <3292577.7s5MMGUR32@thomas> (raw)
In-Reply-To: <20230711084206.25e7b530@hermes.local>
11/07/2023 17:42, Stephen Hemminger:
> On Sat, 26 Mar 2022 00:32:07 -0700
> Vipin Varghese <vipin.varghese@amd.com> wrote:
>
> > +
> > + output = " Socket " + str(socket).ljust(3, ' ') + " Numa " + str(numa).zfill(1) + " "
> > + #output = " Socket " + str(socket).zfill(1) + " Numa " + str(numa).zfill(1) + " "
> > + print(output)
> > + print(format("-" * len(output)))
> > +
> > + for index,coreSibling in enumerate(numa_map[keys]):
> > + print ("Core " + str(index).ljust(3, ' ') + " " + str(coreSibling))
> > + #print ("Core " + str(index).zfill(3) + " " + str(coreSibling))
> > +print("")
> > +
>
> Git complains because you added new blank line at end of file.
>
> One wording suggestion would be to use the term "Node" instead of "Numa" in the table.
> And fix heading alignment. The new headings don't look right.
>
> For the case with only single socket, single node, some of the headings could be
> dropped as well.
I don't understand why we continue working on this script.
I thought we agreed it should be removed in favor of lstopo.
next prev parent reply other threads:[~2023-07-11 16:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-26 7:32 Vipin Varghese
2022-03-26 9:46 ` Thomas Monjalon
2022-03-28 2:56 ` Varghese, Vipin
2022-03-28 7:44 ` Tummala, Sivaprasad
2023-06-14 10:48 ` Ferruh Yigit
2023-06-14 11:25 ` Dmitry Kozlyuk
2023-06-14 14:30 ` Thomas Monjalon
2023-07-11 6:38 ` Varghese, Vipin
2023-07-11 15:42 ` Stephen Hemminger
2023-07-11 16:26 ` Thomas Monjalon [this message]
2023-07-14 9:14 ` Varghese, Vipin
2023-07-17 15:07 ` Thomas Monjalon
2023-07-18 10:37 ` Varghese, Vipin
2023-07-18 14:45 ` Thomas Monjalon
2023-08-12 11:39 ` Varghese, Vipin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3292577.7s5MMGUR32@thomas \
--to=thomas@monjalon.net \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=sivaprasad.tummala@amd.com \
--cc=stephen@networkplumber.org \
--cc=vipin.varghese@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).