From: "Hunt, David" <david.hunt@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, john.mcnamara@intel.com, marko.kovacevic@intel.com
Subject: Re: [dpdk-dev] [PATCH] Update release notes for container power policies
Date: Wed, 17 Oct 2018 13:34:24 +0100 [thread overview]
Message-ID: <32e02310-aea4-7c3e-915e-34bdbb17a1ca@intel.com> (raw)
In-Reply-To: <1539779565.285794.1545097600.5D9A232A@webmail.messagingengine.com>
On 17/10/2018 1:32 PM, Thomas Monjalon wrote:
> Hunt, David:
>> On 17/10/2018 12:43 PM, Thomas Monjalon wrote:
>>> 17/10/2018 13:23, David Hunt:
>>>> Signed-off-by: David Hunt <david.hunt@intel.com>
>>>> ---
>>>> doc/guides/rel_notes/release_18_11.rst | 7 +++++++
>>>> 1 file changed, 7 insertions(+)
>>> Why this patch is alone? It is for a change already applied?
>>> If you forgot the release notes, you should add a Fixes: line
>>> so we know which code change it refers.
>>> Thanks
>> The related patch set is not merged yet, so I could not add a Fixes: line.
>> This is in reference to one of the patch sets I mentioned in an email to
>> you yesterday.
>> http://patches.dpdk.org/project/dpdk/list/?series=1628
>>
>>
>>>> diff --git a/doc/guides/rel_notes/release_18_11.rst b/doc/guides/rel_notes/release_18_11.rst
>>>> index 9c00e33cc..3174a0f80 100644
>>>> --- a/doc/guides/rel_notes/release_18_11.rst
>>>> +++ b/doc/guides/rel_notes/release_18_11.rst
>>>> @@ -88,6 +88,13 @@ New Features
>>>> the specified port. The port must be stopped before the command call in order
>>>> to reconfigure queues.
>>>>
>>>> +* **Added JSON power policy interface for containers .**
>>>> +
>>>> + Extended the Power Library and vm_power_manger sample app to allow power
>>>> + policies to be submitted via a FIFO using JSON formatted strings. Previously
>>>> + limited to Virtual Machines, this feature extends power policy functionality
>>>> + to containers and host applications that need to have their cores frequency
>>>> + controlled based on the rules contained in the policy.
>>>>
>>>> API Changes
>>>> -----------
>>> You must keep a double blank line before before next heading.
>>>
>>> Anyway you should move it before testpmd note, as explained in the comment:
>>> Suggested order in release notes items:
>>> * Core libs (EAL, mempool, ring, mbuf, buses)
>>> * Device abstraction libs and PMDs
>>> - ethdev (lib, PMDs)
>>> - cryptodev (lib, PMDs)
>>> - eventdev (lib, PMDs)
>>> - etc
>>> * Other libs
>>> * Apps, Examples, Tools (if significative)
>>>
>> I can hold off uploading a v2 of this patch until the main patch set is
>> merged? Then I can
>> add in a Fixes: line and make your suggested changes.
> In this case, it is a lot better to integrate it with one of the patches of your series,
> maybe with the doc patch?
Sure. Sounds like the best option. I'll upload shortly.
Thanks,
Dave.
prev parent reply other threads:[~2018-10-17 12:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-17 11:23 David Hunt
2018-10-17 11:43 ` Thomas Monjalon
2018-10-17 12:04 ` Hunt, David
2018-10-17 12:32 ` Thomas Monjalon
2018-10-17 12:34 ` Hunt, David [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32e02310-aea4-7c3e-915e-34bdbb17a1ca@intel.com \
--to=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=marko.kovacevic@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).