From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>
Cc: dev@dpdk.org, Adrien Mazarguil <adrien.mazarguil@6wind.com>,
Wenzhuo Lu <wenzhuo.lu@intel.com>,
Jingjing Wu <jingjing.wu@intel.com>,
Bernard Iremonger <bernard.iremonger@intel.com>,
Mohammad Abdul Awal <mohammad.abdul.awal@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2 0/2] app/testpmd implement VXLAN/NVGRE Encap/Decap
Date: Mon, 18 Jun 2018 15:40:53 +0100 [thread overview]
Message-ID: <3311e792-134b-b8d3-0a9b-7695877ac671@intel.com> (raw)
In-Reply-To: <20180618093843.y34xrnrgjjpm5myf@laranjeiro-vm.dev.6wind.com>
On 6/18/2018 10:38 AM, Nélio Laranjeiro wrote:
> On Mon, Jun 18, 2018 at 10:05:03AM +0100, Ferruh Yigit wrote:
>> On 6/18/2018 9:52 AM, Nelio Laranjeiro wrote:
>>> This series adds an easy and maintainable configuration version support for
>>> those two actions for 18.08 by using global variables in testpmd to store the
>>> necessary information for the tunnel encapsulation. Those variables are used
>>> in conjunction of RTE_FLOW_ACTION_{VXLAN,NVGRE}_ENCAP action to create easily
>>> the action for flows.
>>>
>>> A common way to use it:
>>>
>>> set vxlan ipv4 4 4 4 127.0.0.1 128.0.0.1 11:11:11:11:11:11 22:22:22:22:22:22
>>> flow create 0 ingress pattern end actions vxlan_encap / queue index 0 / end
>>>
>>> set vxlan ipv6 4 4 4 ::1 ::2222 11:11:11:11:11:11 22:22:22:22:22:22
>>> flow create 0 ingress pattern end actions vxlan_encap / queue index 0 / end
>>>
>>> set nvgre ipv4 4 127.0.0.1 128.0.0.1 11:11:11:11:11:11 22:22:22:22:22:22
>>> flow create 0 ingress pattern end actions nvgre_encap / queue index 0 / end
>>>
>>> set nvgre ipv6 4 ::1 ::2222 11:11:11:11:11:11 22:22:22:22:22:22
>>> flow create 0 ingress pattern end actions nvgre_encap / queue index 0 / end
>>>
>>> This also replace the proposal done by Mohammad Abdul Awal [1] which handles
>>> in a more complex way for the same work.
>>
>> Hi Nelio,
>>
>> Is this set on top of mentioned set?
>
> Hi Ferruh,
>
> No it is another implementation of Declan's API. It can be directly
> applied on top of the current DPDK code without any other patch.
I mean "based on" more than "on top of". So if this code is based on referenced
patchset, I believe it should keep original sign-off.
If this code is completely new implementation that replaces referenced patchset,
I believe it would be nice to comment on the original patch or communicate about
it instead of just sending another set to replace original one.
>
>> If so shouldn't the set has the Awal's sign-off too?
>> Are you replacing someone else patch with dropping his sign-off?
>>
>>> Note this API has already a modification planned for 18.11 [2] thus those
>>> series should have a limited life for a single release.
>>>
>>> [1] https://dpdk.org/ml/archives/dev/2018-May/101403.html
>>> [2] https://dpdk.org/ml/archives/dev/2018-June/103485.html
>>>
>>>
>>> Changes in v2:
>>>
>>> - add default IPv6 values for NVGRE encapsulation.
>>> - replace VXLAN to NVGRE in comments concerning NVGRE layer.
>>>
>>> Nelio Laranjeiro (2):
>>> app/testpmd: add VXLAN encap/decap support
>>> app/testpmd: add NVGRE encap/decap support
>>>
>>> app/test-pmd/cmdline.c | 169 +++++++++++++
>>> app/test-pmd/cmdline_flow.c | 248 ++++++++++++++++++++
>>> app/test-pmd/testpmd.c | 28 +++
>>> app/test-pmd/testpmd.h | 28 +++
>>> doc/guides/testpmd_app_ug/testpmd_funcs.rst | 25 ++
>>> 5 files changed, 498 insertions(+)
>
next prev parent reply other threads:[~2018-06-18 14:40 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-14 15:08 [dpdk-dev] [PATCH 0/2] implement VXLAN/NVGRE Encap/Decap in testpmd Nelio Laranjeiro
2018-06-14 15:08 ` [dpdk-dev] [PATCH 1/2] app/testpmd: add VXLAN encap/decap support Nelio Laranjeiro
2018-06-14 15:09 ` [dpdk-dev] [PATCH 2/2] app/testpmd: add NVGRE " Nelio Laranjeiro
2018-06-15 9:32 ` Iremonger, Bernard
2018-06-15 11:25 ` Nélio Laranjeiro
2018-06-18 8:52 ` [dpdk-dev] [PATCH v2 0/2] app/testpmd implement VXLAN/NVGRE Encap/Decap Nelio Laranjeiro
2018-06-18 9:05 ` Ferruh Yigit
2018-06-18 9:38 ` Nélio Laranjeiro
2018-06-18 14:40 ` Ferruh Yigit [this message]
2018-06-19 7:32 ` Nélio Laranjeiro
2018-06-18 14:36 ` [dpdk-dev] [PATCH v3 " Nelio Laranjeiro
2018-06-18 16:28 ` Iremonger, Bernard
2018-06-19 9:41 ` Nélio Laranjeiro
2018-06-21 7:13 ` [dpdk-dev] [PATCH v4 " Nelio Laranjeiro
2018-06-21 7:13 ` [dpdk-dev] [PATCH v4 1/2] app/testpmd: add VXLAN encap/decap support Nelio Laranjeiro
2018-06-26 10:51 ` Ori Kam
2018-06-26 12:43 ` Iremonger, Bernard
2018-06-21 7:13 ` [dpdk-dev] [PATCH v4 2/2] app/testpmd: add NVGRE " Nelio Laranjeiro
2018-06-26 10:48 ` Ori Kam
2018-06-26 12:48 ` Iremonger, Bernard
2018-06-26 15:15 ` Nélio Laranjeiro
2018-06-22 7:42 ` [dpdk-dev] [PATCH v4 0/2] app/testpmd implement VXLAN/NVGRE Encap/Decap Mohammad Abdul Awal
2018-06-22 8:31 ` Nélio Laranjeiro
2018-06-22 8:51 ` Mohammad Abdul Awal
2018-06-22 9:08 ` Nélio Laranjeiro
2018-06-22 10:19 ` Mohammad Abdul Awal
2018-06-26 15:15 ` Nélio Laranjeiro
2018-06-27 8:53 ` [dpdk-dev] [PATCH v5 " Nelio Laranjeiro
2018-06-27 8:53 ` [dpdk-dev] [PATCH v5 1/2] app/testpmd: add VXLAN encap/decap support Nelio Laranjeiro
2018-06-27 8:53 ` [dpdk-dev] [PATCH v5 2/2] app/testpmd: add NVGRE " Nelio Laranjeiro
2018-06-27 9:53 ` [dpdk-dev] [PATCH v6 0/2] app/testpmd implement VXLAN/NVGRE Encap/Decap Nelio Laranjeiro
2018-06-27 9:53 ` [dpdk-dev] [PATCH v6 1/2] app/testpmd: add VXLAN encap/decap support Nelio Laranjeiro
2018-06-27 9:53 ` [dpdk-dev] [PATCH v6 2/2] app/testpmd: add NVGRE " Nelio Laranjeiro
2018-06-27 10:00 ` [dpdk-dev] [PATCH v6 0/2] app/testpmd implement VXLAN/NVGRE Encap/Decap Nélio Laranjeiro
2018-06-27 11:45 ` [dpdk-dev] [PATCH v7 " Nelio Laranjeiro
2018-06-27 11:45 ` [dpdk-dev] [PATCH v7 1/2] app/testpmd: add VXLAN encap/decap support Nelio Laranjeiro
2018-06-27 11:45 ` [dpdk-dev] [PATCH v7 2/2] app/testpmd: add NVGRE " Nelio Laranjeiro
2018-07-02 10:40 ` [dpdk-dev] [PATCH v7 0/2] app/testpmd implement VXLAN/NVGRE Encap/Decap Mohammad Abdul Awal
2018-07-04 14:54 ` Ferruh Yigit
2018-07-05 9:37 ` Nélio Laranjeiro
2018-07-05 14:33 ` [dpdk-dev] [PATCH v8 " Nelio Laranjeiro
2018-07-05 14:33 ` [dpdk-dev] [PATCH v8 1/2] app/testpmd: add VXLAN encap/decap support Nelio Laranjeiro
2018-07-05 15:03 ` Mohammad Abdul Awal
2018-07-05 14:33 ` [dpdk-dev] [PATCH v8 2/2] app/testpmd: add NVGRE " Nelio Laranjeiro
2018-07-05 15:07 ` Mohammad Abdul Awal
2018-07-05 15:17 ` Nélio Laranjeiro
2018-07-05 14:48 ` [dpdk-dev] [PATCH v8 0/2] app/testpmd implement VXLAN/NVGRE Encap/Decap Adrien Mazarguil
2018-07-05 14:57 ` Mohammad Abdul Awal
2018-07-06 6:43 ` [dpdk-dev] [PATCH v9 " Nelio Laranjeiro
2018-07-06 6:43 ` [dpdk-dev] [PATCH v9 1/2] app/testpmd: add VXLAN encap/decap support Nelio Laranjeiro
2018-07-06 6:43 ` [dpdk-dev] [PATCH v9 2/2] app/testpmd: add NVGRE " Nelio Laranjeiro
2018-07-18 8:31 ` [dpdk-dev] [PATCH v9 0/2] app/testpmd implement VXLAN/NVGRE Encap/Decap Ferruh Yigit
2018-06-18 14:36 ` [dpdk-dev] [PATCH v3 1/2] app/testpmd: add VXLAN encap/decap support Nelio Laranjeiro
2018-06-19 7:09 ` Ori Kam
2018-06-19 9:40 ` Nélio Laranjeiro
2018-06-18 14:36 ` [dpdk-dev] [PATCH v3 2/2] app/testpmd: add NVGRE " Nelio Laranjeiro
2018-06-19 7:08 ` Ori Kam
2018-06-18 8:52 ` [dpdk-dev] [PATCH v2 1/2] app/testpmd: add VXLAN " Nelio Laranjeiro
2018-06-18 12:47 ` Mohammad Abdul Awal
2018-06-18 21:02 ` Stephen Hemminger
2018-06-19 9:44 ` Nélio Laranjeiro
2018-06-18 8:52 ` [dpdk-dev] [PATCH v2 2/2] app/testpmd: add NVGRE " Nelio Laranjeiro
2018-06-18 12:48 ` Mohammad Abdul Awal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3311e792-134b-b8d3-0a9b-7695877ac671@intel.com \
--to=ferruh.yigit@intel.com \
--cc=adrien.mazarguil@6wind.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=mohammad.abdul.awal@intel.com \
--cc=nelio.laranjeiro@6wind.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).