From: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>, Gregory Etelson <gregory@weka.io>
Cc: dev@dpdk.org, Ilya Maximets <i.maximets@samsung.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
Jerin Jacob <jerin.jacob@caviumnetworks.com>,
"hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>
Subject: Re: [dpdk-dev] [PATCH] eal: use get_mempolicy(2) to find numa socket on Linux
Date: Mon, 3 Jul 2017 15:11:11 +0100 [thread overview]
Message-ID: <33607ba3-f359-de3e-1351-66140e693a44@intel.com> (raw)
In-Reply-To: <4398639.Xci2ANazcN@xps>
On 01/07/2017 15:18, Thomas Monjalon wrote:
> 21/06/2017 17:49, Sergio Gonzalez Monroy:
>> I think following the discussion of libnuma dependency in another thread
>> [1], you would need to implement a similar approach and keep the old
>> method while providing this alternative if libnuma is present.
> Considering that libnuma becomes mandatory to build DPDK on NUMA-capable
> systems, we can assume there is only one CPU socket if libnuma is
> unavailable.
>
>> As Ilya mentions in the thread, this is usually the job of tools such as
>> autotools, cmake or meson but given that we do not have such tools in
>> DPDK yet, we rely in a build time config option for libnuma.
>>
>> Given that we already have a libnuma config option for VHOST, we might
>> be adding anew one for hugepage balancing, I think it would make sense
>> to just have single CONFIG_RTE_LIBNUMA option instead.
>>
>> Thoughts?
> I am not sure about merging every NUMA options into one.
> It may be interesting to track different NUMA features requiring libnuma.
Do you see the case where a system with libnuma we want to use the
support for hugapage allocation but not for vhost?
In my opinion this looks like a manual check for libnuma where with a
different build system would have been automated.
Cheers,
Sergio
> Anyway, this patch needs to be rebased now that Ilya's patch is applied.
next prev parent reply other threads:[~2017-07-03 14:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-18 15:52 Gregory Etelson
2017-06-21 15:49 ` Sergio Gonzalez Monroy
2017-07-01 14:18 ` Thomas Monjalon
2017-07-03 14:11 ` Sergio Gonzalez Monroy [this message]
2017-07-03 14:20 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33607ba3-f359-de3e-1351-66140e693a44@intel.com \
--to=sergio.gonzalez.monroy@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=gregory@weka.io \
--cc=hemant.agrawal@nxp.com \
--cc=i.maximets@samsung.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).