From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: David Marchand <david.marchand@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 3/3] ethdev: prevent segfaults in rte_eth_dev_is_detachable
Date: Tue, 03 Nov 2015 12:20:02 +0100 [thread overview]
Message-ID: <33652013.vVXR4tZhrp@xps13> (raw)
In-Reply-To: <CALwxeUvb58juALvGn2Lt9doYrfx0rbQCYWL0q1SSV2jHfm8HbQ@mail.gmail.com>
2015-11-03 12:19, David Marchand:
> On Tue, Nov 3, 2015 at 12:10 PM, Thomas Monjalon <thomas.monjalon@6wind.com>
> wrote:
>
> > 2015-10-29 09:55, David Marchand:
> > > From: Maxime Leroy <maxime.leroy@6wind.com>
> > >
> > > Some drivers like virtual ones don't specify any driver pointer in the
> > > structure rte_eth_dev.
> > >
> > > To prevent segfault, we should check if this pointer is NULL before
> > > dereferencing it.
> > >
> > > Signed-off-by: Maxime Leroy <maxime.leroy@6wind.com>
> > > Signed-off-by: David Marchand <david.marchand@6wind.com>
> >
> > It is not clear what the problem is.
> > And the driver fields should probably be removed or changed as it too
> > tigthly
> > related to the PCI driver.
> >
>
> It does look odd to me as well, quickly went through head, and did not see
> a case where this could happen.
> Maxime is not available at the moment, so I think I will just drop this
> patch.
>
> How about this patchset rebased on head with just the first two patches ?
Perfect, thanks
next prev parent reply other threads:[~2015-11-03 11:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-29 8:55 [dpdk-dev] [PATCH 0/3] export hotplug capability David Marchand
2015-10-29 8:55 ` [dpdk-dev] [PATCH 1/3] ethdev: rework value return by rte_eth_dev_is_detachable David Marchand
2015-10-29 8:55 ` [dpdk-dev] [PATCH 2/3] ethdev: export rte_eth_dev_is_detachable function David Marchand
2015-10-29 8:55 ` [dpdk-dev] [PATCH 3/3] ethdev: prevent segfaults in rte_eth_dev_is_detachable David Marchand
2015-11-03 11:10 ` Thomas Monjalon
2015-11-03 11:19 ` David Marchand
2015-11-03 11:20 ` Thomas Monjalon [this message]
2015-11-03 11:34 ` [dpdk-dev] [PATCH v2 0/2] export hotplug capability David Marchand
2015-11-03 11:34 ` [dpdk-dev] [PATCH v2 1/2] ethdev: rework value return by rte_eth_dev_is_detachable David Marchand
2015-11-03 11:35 ` [dpdk-dev] [PATCH v2 2/2] ethdev: export rte_eth_dev_is_detachable function David Marchand
2015-11-03 13:50 ` Thomas Monjalon
2015-11-04 7:49 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33652013.vVXR4tZhrp@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=david.marchand@6wind.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).