From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Hyong Youb Kim <hyonkim@cisco.com>
Cc: dev@dpdk.org, John Daley <johndale@cisco.com>, stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH] net/enic: fix max MTU calculation
Date: Wed, 20 Mar 2019 14:30:12 +0000 [thread overview]
Message-ID: <33896683-bf48-6d6b-c8a7-c6f94b3f65eb@intel.com> (raw)
In-Reply-To: <20190314110532.22638-1-hyonkim@cisco.com>
On 3/14/2019 11:05 AM, Hyong Youb Kim wrote:
> The maximum packet length (max_pkt_len) from the firmware does not
> include CRC, so do not subtract 4 when deriving the max MTU. This
> change effectively increases the max MTU by 4B. Apps often assume max
> MTU = max_rx_pkt_len - 14 (ethernet header), and attempt to set the
> MTU to that value (i.e. set MTU to max HW value). This change
> incidentally allows such apps to change MTU to max value successfully.
>
> Fixes: bb34ffb848a0 ("net/enic: determine max egress packet size and max MTU")
> Cc: stable@dpdk.org
>
> Signed-off-by: Hyong Youb Kim <hyonkim@cisco.com>
> Reviewed-by: John Daley <johndale@cisco.com>
Applied to dpdk-next-net/master, thanks.
prev parent reply other threads:[~2019-03-20 14:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-14 11:05 Hyong Youb Kim
2019-03-20 14:30 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33896683-bf48-6d6b-c8a7-c6f94b3f65eb@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=hyonkim@cisco.com \
--cc=johndale@cisco.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).