From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Guo, Jia" <jia.guo@intel.com>
Cc: "Guo, Junfeng" <junfeng.guo@intel.com>,
"Zhang, AlvinX" <alvinx.zhang@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Xing, Beilei" <beilei.xing@intel.com>
Subject: Re: [dpdk-dev] [PATCH v3] net/iavf: refactor RSS
Date: Wed, 9 Sep 2020 05:20:00 +0000 [thread overview]
Message-ID: <33ed2dbd6f834071957f40d272f044d5@intel.com> (raw)
In-Reply-To: <7296c0f7e025446d8f95af7d3e006565@intel.com>
> -----Original Message-----
> From: Guo, Jia <jia.guo@intel.com>
> Sent: Wednesday, September 9, 2020 1:16 PM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: Guo, Junfeng <junfeng.guo@intel.com>; Zhang, AlvinX
> <alvinx.zhang@intel.com>; dev@dpdk.org; Xing, Beilei <beilei.xing@intel.com>
> Subject: RE: [PATCH v3] net/iavf: refactor RSS
>
> Acked-by: Jeff Guo <jia.guo@intel.com>
>
> Best regards,
> Jeff Guo
>
> > -----Original Message-----
> > From: Zhang, Qi Z <qi.z.zhang@intel.com>
> > Sent: Wednesday, September 9, 2020 1:16 PM
> > To: Guo, Jia <jia.guo@intel.com>
> > Cc: Guo, Junfeng <junfeng.guo@intel.com>; Zhang, AlvinX
> > <alvinx.zhang@intel.com>; dev@dpdk.org; Xing, Beilei
> > <beilei.xing@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
> > Subject: [PATCH v3] net/iavf: refactor RSS
> >
> > Current RSS implementation is not easy to scale and maintain.
> > The patch refactor the code base on below design:
> >
> > 1. iavf_pattern_match_item->input_set_mask is the superset of
> > ETH_RSS_xxx.
> > 2. iavf_pattern_match_item->meta is the virtchnl_proto_hdrs template.
> > 3. iavf_hash_parse_pattern will generate pattern hint.
> > 4. iavf_hash_parse_action will refine the virtchnl_proto_hdrs base on
> > pattern hint and ETH_RSS_xxx.
> > 5. The refine process include
> > 1) refine field selector of l2, l3, l4.
> > 2) insert gtpu proto_hdr at the beginning base on pattern hint.
> > 3) refine field selector for gtpu header.
> >
> > The patch reduce the code from 4000+ line to less than 1000.
> >
> > Note:
> > The variable iavf_hash_pattern_list as the manifest of all supported
> > pattern is intend to break the 80 char limitation for better review
> > experience.
> >
> > Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
prev parent reply other threads:[~2020-09-09 5:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-09 5:16 Qi Zhang
2020-09-09 5:15 ` Guo, Jia
2020-09-09 5:20 ` Zhang, Qi Z [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33ed2dbd6f834071957f40d272f044d5@intel.com \
--to=qi.z.zhang@intel.com \
--cc=alvinx.zhang@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=jia.guo@intel.com \
--cc=junfeng.guo@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).