From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Ben Walker <benjamin.walker@intel.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] Fix overwriting of dev_flags in rte_eth_dev after initialization
Date: Thu, 9 Feb 2017 17:37:41 +0000 [thread overview]
Message-ID: <340ab2a6-8065-7413-2a28-38fb383f7bd9@intel.com> (raw)
In-Reply-To: <20170209164006.72040-1-benjamin.walker@intel.com>
On 2/9/2017 4:40 PM, Ben Walker wrote:
> rte_eth_copy_pci_info no longer sets RTE_ETH_DEV_DETACHABLE
> as per my previous patch, but it still does initialize
> the dev_flags. In a number of cases, a later assignment to
> dev_flags to set RTE_ETH_DEV_DETACHABLE was overwriting
> the previously initialized value.
>
> Pointed out by Michael Larsen.
>
> Signed-off-by: Ben Walker <benjamin.walker@intel.com>
Thanks Ben,
A patch already sent for this:
http://dpdk.org/dev/patchwork/patch/20248/
(indeed two: http://dpdk.org/dev/patchwork/patch/20163/)
and applied to next-net:
http://dpdk.org/browse/next/dpdk-next-net/commit/?id=ae94e2a23b5
Thanks,
ferruh
prev parent reply other threads:[~2017-02-09 17:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-09 16:40 Ben Walker
2017-02-09 17:37 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=340ab2a6-8065-7413-2a28-38fb383f7bd9@intel.com \
--to=ferruh.yigit@intel.com \
--cc=benjamin.walker@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).