From: Thomas Monjalon <thomas@monjalon.net>
To: Ori Kam <orika@nvidia.com>, Ferruh Yigit <ferruh.yigit@amd.com>,
Kiran Kumar K <kirankumark@marvell.com>
Cc: Aman Singh <aman.deep.singh@intel.com>,
Yuying Zhang <yuying.zhang@intel.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
dev@dpdk.org
Subject: Re: [PATCH v2] ethdev: add Tx queue flow matching item
Date: Thu, 08 Jun 2023 21:59:30 +0200 [thread overview]
Message-ID: <3422979.uBEoKPz9u1@thomas> (raw)
In-Reply-To: <20230508134935.971197-1-kirankumark@marvell.com>
08/05/2023 15:49, kirankumark@marvell.com:
> From: Kiran Kumar K <kirankumark@marvell.com>
>
> Adding support for Tx queue flow matching item.
> This item is valid only for egress rules.
> An example use case would be that application can
> set different vlan insert rules with different PCP values
> based on Tx queue number.
>
> Signed-off-by: Kiran Kumar K <kirankumark@marvell.com>
> ---
> app/test-pmd/cmdline_flow.c | 28 +++++++++++++++++++++
> doc/guides/prog_guide/rte_flow.rst | 7 ++++++
> doc/guides/rel_notes/release_23_07.rst | 5 ++++
> doc/guides/testpmd_app_ug/testpmd_funcs.rst | 4 +++
> lib/ethdev/rte_flow.c | 1 +
> lib/ethdev/rte_flow.h | 26 +++++++++++++++++++
> 6 files changed, 71 insertions(+)
That's only 71 lines but I could make 10 comments.
I'm fixing spacing, alignment, sorting, etc while pulling next-net,
but it would have been more confortable if more attention was paid
by the author and the reviewers.
I have a question though (it could be fixed in a later patch):
> +struct rte_flow_item_tx_queue {
> + /** Tx queue number that packet is being transmitted */
> + uint16_t tx_queue;
> +};
This field is used with host endianness, right?
> +static const struct rte_flow_item_tx_queue rte_flow_item_tx_queue_mask = {
> + .tx_queue = RTE_BE16(0xffff),
> +};
So why using RTE_BE16 to set a field which is not specifically big endian?
(not talking about the fact that 0xffff is the same no matter the endianness,
and not talking about the fact that it is better to use UINT16_MAX).
next prev parent reply other threads:[~2023-06-08 19:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-08 13:49 kirankumark
2023-05-17 17:01 ` Ori Kam
2023-06-08 19:59 ` Thomas Monjalon [this message]
2023-06-29 15:33 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3422979.uBEoKPz9u1@thomas \
--to=thomas@monjalon.net \
--cc=aman.deep.singh@intel.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=kirankumark@marvell.com \
--cc=orika@nvidia.com \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).