From: "Doherty, Declan" <declan.doherty@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] eal / malloc : alignment parameter check failing due to changes in rte_is_power_of_2
Date: Sun, 18 Jan 2015 19:26:26 +0000 [thread overview]
Message-ID: <345C63BAECC1AD42A2EC8C63AFFC3ADC2747EE3D@IRSMSX101.ger.corp.intel.com> (raw)
In-Reply-To: <1555477.4KJeR5JQaW@xps13>
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Friday, January 16, 2015 5:02 PM
> To: Doherty, Declan
> Cc: dev@dpdk.org; De Lara Guarch, Pablo
> Subject: Re: [dpdk-dev] [PATCH] eal / malloc : alignment parameter check failing
> due to changes in rte_is_power_of_2
>
> 2015-01-16 15:10, Declan Doherty:
> > In commit 2fc8d6d the behaviour of function rte_is_power_of_2 was
> > changed to not return true for 0. memzone_reserve_aligned_thread_unsafe
> > and rte_malloc_socket both make the assumption that for align = 0
> > !rte_is_power_of_2(align) will return false. This patch adds a check
> > that align parameter is non-zero before doing the power of 2 check
> >
> > Signed-off-by: Declan Doherty <declan.doherty@intel.com>
> [...]
> > - if (!rte_is_power_of_2(align)) {
> > + if (align ? !rte_is_power_of_2(align) : 0) {
> [...]
> > - if (size == 0 || !rte_is_power_of_2(align))
> > + if (size == 0 || align ? !rte_is_power_of_2(align) : 0)
>
> I don't understand why you write "align ? !rte_is_power_of_2(align) : 0"
> instead of the more readable "align && !rte_is_power_of_2(align)" ?
>
> Pablo acked it so I guess there is something obvious I'm missing.
>
> --
> Thomas
No there's nothing you're missing, this is just the way I saw the logic, if align is none
zero, then test the power of 2 condition otherwise return 0. I have no problem with
your suggestion in you prefer that, at the end of the day the logic test works out equivalent.
next prev parent reply other threads:[~2015-01-18 19:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-16 15:10 Declan Doherty
2015-01-16 15:37 ` De Lara Guarch, Pablo
2015-01-16 17:01 ` Thomas Monjalon
2015-01-18 19:26 ` Doherty, Declan [this message]
2015-01-19 9:00 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=345C63BAECC1AD42A2EC8C63AFFC3ADC2747EE3D@IRSMSX101.ger.corp.intel.com \
--to=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).