DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Leo Xu <yongquanx@nvidia.com>
Cc: dev@dpdk.org, Matan Azrad <matan@nvidia.com>,
	Viacheslav Ovsiienko <viacheslavo@nvidia.com>
Subject: Re: [PATCH v2 3/3] net/mlx5/hws: add ICMPv6 ID and sequence match support
Date: Wed, 18 Jan 2023 09:58:05 +0100	[thread overview]
Message-ID: <3467707.0WQXIW03uk@thomas> (raw)
In-Reply-To: <20221220074403.1015411-4-yongquanx@nvidia.com>

20/12/2022 08:44, Leo Xu:
> This patch adds ICMPv6 ID and sequence match support for HWS.
> Since type and code of ICMPv6 echo is already specified by ITEM type:
>   RTE_FLOW_ITEM_TYPE_ICMP6_ECHO_REQUEST
>   RTE_FLOW_ITEM_TYPE_ICMP6_ECHO_REPLY
> mlx5 pmd will set appropriate type and code automatically:
>   Echo request: type(128), code(0)
>   Echo reply:   type(129), code(0)
> type and code provided by application will be ignored
> 
> This patch also fixes these issues in ICMP definer.
> 1. Parsing inner ICMP item gets and overwrites the outer IP_PROTOCOL
> function, which will remove the outer L4 match incorrectly. Fix this
> by getting correct inner function.
> 2. Member order of mlx5_ifc_header_icmp_bits doesn't follow ICMP format.
> Reorder them to make it more consistent.

Please don't fix stuff in the same patch as a new feature.
You should have one patch per fix.
The code for the new feature may be squashed in the other mlx5 patch for the feature.



  reply	other threads:[~2023-01-18  8:58 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-12  8:59 [PATCH 0/3] support match icmpv6 id and sequence Leo Xu
2022-12-12  8:59 ` [PATCH 1/3] ethdev: add ICMPv6 " Leo Xu
2022-12-12  8:59 ` [PATCH 2/3] net/mlx5: add ICMPv6 id and sequence match support Leo Xu
2022-12-12  8:59 ` [PATCH 3/3] net/mlx5/hws: " Leo Xu
2022-12-20  7:44 ` [PATCH v2 0/3] support match icmpv6 ID and sequence Leo Xu
2022-12-20  7:44   ` [PATCH v2 1/3] ethdev: add ICMPv6 " Leo Xu
2023-01-03  8:17     ` Ori Kam
2023-01-18  9:30     ` Thomas Monjalon
2023-01-31  6:53       ` Leo Xu (Networking SW)
2023-02-01  9:56         ` Thomas Monjalon
2023-02-02 18:33           ` Leo Xu (Networking SW)
2023-02-02 21:23             ` Thomas Monjalon
2023-02-03  2:56               ` Leo Xu (Networking SW)
2023-01-26 10:45     ` Ferruh Yigit
2023-01-31  3:58       ` Leo Xu (Networking SW)
2022-12-20  7:44   ` [PATCH v2 2/3] net/mlx5: add ICMPv6 ID and sequence match support Leo Xu
2023-01-18  8:55     ` Thomas Monjalon
2023-01-31  6:57       ` Leo Xu (Networking SW)
2022-12-20  7:44   ` [PATCH v2 3/3] net/mlx5/hws: " Leo Xu
2023-01-18  8:58     ` Thomas Monjalon [this message]
2023-01-31  6:56       ` Leo Xu (Networking SW)
2023-01-26 10:47   ` [PATCH v2 0/3] support match icmpv6 ID and sequence Ferruh Yigit
2023-01-31  3:54     ` Leo Xu (Networking SW)
2023-02-05 13:41   ` [PATCH v3 " Leo Xu
2023-02-05 13:41     ` [PATCH v3 1/3] ethdev: add ICMPv6 " Leo Xu
2023-02-05 13:41     ` [PATCH v3 2/3] net/mlx5: add ICMPv6 ID and sequence match support Leo Xu
2023-02-07 13:48       ` Slava Ovsiienko
2023-02-05 13:41     ` [PATCH v3 3/3] net/mlx5/hws: " Leo Xu
2023-02-07 13:05       ` Alex Vesker
2023-02-07 13:49       ` Slava Ovsiienko
2023-02-09 13:04     ` [PATCH v3 0/3] support match icmpv6 ID and sequence Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3467707.0WQXIW03uk@thomas \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=matan@nvidia.com \
    --cc=viacheslavo@nvidia.com \
    --cc=yongquanx@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).