From: Hemant Agrawal <hemant.agrawal@nxp.com>
To: Olivier MATZ <olivier.matz@6wind.com>,
Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>, <dev@dpdk.org>,
<shreyansh.jain@nxp.com>
Subject: Re: [dpdk-dev] [PATCH v2] mempool/dpaa2: add DPAA2 hardware offloaded mempool
Date: Tue, 11 Apr 2017 19:24:40 +0530 [thread overview]
Message-ID: <346d87ec-b57c-bc80-68b6-4ac9f76d48da@nxp.com> (raw)
In-Reply-To: <20170411145612.4bd8ed34@neon>
Hi Thomas,
On 4/11/2017 6:26 PM, Olivier MATZ wrote:
> On Tue, 11 Apr 2017 14:50:14 +0200
> Thomas Monjalon <thomas.monjalon@6wind.com> wrote:
>
>> 2017-04-11 09:39, Ferruh Yigit:
>>> On 4/11/2017 8:50 AM, Thomas Monjalon wrote:
>>>> 2017-04-11 11:28, Hemant Agrawal:
>>>>> On 4/11/2017 1:28 AM, Olivier MATZ wrote:
>>>>>> Hemant Agrawal <hemant.agrawal@nxp.com> wrote:
>>>>>>> --- a/drivers/bus/Makefile
>>>>>>> +++ b/drivers/bus/Makefile
>>>>>>> @@ -33,6 +33,10 @@ include $(RTE_SDK)/mk/rte.vars.mk
>>>>>>>
>>>>>>> core-libs := librte_eal librte_mbuf librte_mempool librte_ring librte_ether
>>>>>>>
>>>>>>> +ifeq ($(CONFIG_RTE_LIBRTE_DPAA2_MEMPOOL),y)
>>>>>>> +CONFIG_RTE_LIBRTE_FSLMC_BUS = $(CONFIG_RTE_LIBRTE_DPAA2_MEMPOOL)
>>>>>>> +endif
>>>>>>> +
>>>>>>> DIRS-$(CONFIG_RTE_LIBRTE_FSLMC_BUS) += fslmc
>>>>>>> DEPDIRS-fslmc = ${core-libs}
>>>>>>>
>>>>>>
>>>>>> What's the purpose of this?
>>>>>> Not sure we are allowed to modify the configs in the Makefiles.
>>>>>
>>>>> DPAA2_MEMPOOL will not work without the DPAA2 mempool hw instance
>>>>> detected on FSLMC_BUS.
>>>>> So, it is required that if you are enabling DPAA2_MEMPOOL, FSLMC_BUS is
>>>>> to be enabled.
>>>>>
>>>>> Currently the config structure do not provide such dependency definitions.
>>>>>
>>>>> This was done based on the suggestions on the initial patches from
>>>>> Ferruh and Jerin.
>>>>
>>>> Please do not do that.
>>>> We do not change the configuration in the back of the user.
>>>> This kind of dependency should be managed in the configuration step
>>>> which do not exist yet.
>>>>
>>>> You can use $(error) to stop the compilation instead.
>>>
>>> As Hemant mentioned, this was my suggestion. There is a configuration
>>> dependency here, that we don't have a way to resolve in dpdk.
>>>
>>> If one of the end leaf selected, it makes sense to me to auto select
>>> dependent pieces.
>>
>> A dependency must be solved at configuration time with appropriate
>> user notification.
>> For now, we just check them at compilation time and throw an error.
>
At present, we have removed the config dependency check from the code
and sent the new patch sets.
I am not sure about error part. I will experiment on it and send patches
over these patches. This should not block the existing patches.
> Yes, a good reason for not doing this is because the "make config"
> generates a rte_config.h file. Changing a configuration option at
> one place in a Makefile makes configuration inconsistent.
>
> I don't think it's a blocker issue for the patch integration.
>
> Regards,
> Olivier
>
>
next prev parent reply other threads:[~2017-04-11 13:54 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-17 12:47 [dpdk-dev] [PATCH v1] NXP DPAA2 External Mempool Driver Hemant Agrawal
2017-03-17 12:47 ` [dpdk-dev] [PATCH v1] mempool/dpaa2: add DPAA2 hardware offloaded mempool Hemant Agrawal
2017-03-22 6:09 ` Jianbo Liu
2017-03-23 16:57 ` Hemant Agrawal
2017-03-24 14:57 ` Ferruh Yigit
2017-03-24 15:59 ` Ferruh Yigit
2017-03-24 16:31 ` Olivier Matz
2017-03-24 16:38 ` Ferruh Yigit
2017-03-24 16:42 ` Olivier Matz
2017-03-27 16:30 ` Olivier Matz
2017-03-28 9:45 ` Hemant Agrawal
2017-03-30 11:29 ` Ferruh Yigit
2017-03-30 12:50 ` Hemant Agrawal
2017-03-30 13:52 ` Thomas Monjalon
2017-04-03 14:50 ` Ferruh Yigit
2017-04-09 7:59 ` [dpdk-dev] [PATCH v2] NXP DPAA2 External Mempool Driver Hemant Agrawal
2017-04-09 7:59 ` [dpdk-dev] [PATCH v2] mempool/dpaa2: add DPAA2 hardware offloaded mempool Hemant Agrawal
2017-04-10 19:58 ` Olivier MATZ
2017-04-11 5:58 ` Hemant Agrawal
2017-04-11 7:50 ` Thomas Monjalon
2017-04-11 8:39 ` Ferruh Yigit
2017-04-11 12:50 ` Thomas Monjalon
2017-04-11 12:56 ` Olivier MATZ
2017-04-11 13:54 ` Hemant Agrawal [this message]
2017-04-11 13:42 ` [dpdk-dev] [PATCH v3] NXP DPAA2 External Mempool Driver Hemant Agrawal
2017-04-11 13:42 ` [dpdk-dev] [PATCH v3] mempool/dpaa2: add DPAA2 hardware offloaded mempool Hemant Agrawal
2017-04-12 11:31 ` [dpdk-dev] [PATCH v3] NXP DPAA2 External Mempool Driver Ferruh Yigit
2017-04-12 13:50 ` Ferruh Yigit
2017-03-17 13:42 ` [dpdk-dev] [PATCH v1] " Thomas Monjalon
2017-03-17 17:12 ` Hemant Agrawal
2017-03-17 17:22 ` Olivier Matz
2017-03-20 10:08 ` Hemant Agrawal
2017-04-09 7:50 ` [dpdk-dev] [PATCH v3 00/21] NXP DPAA2 FSLMC Bus driver Hemant Agrawal
2017-04-09 7:50 ` [dpdk-dev] [PATCH v3 01/21] mk/dpaa2: add the crc support to the machine type Hemant Agrawal
2017-04-09 7:50 ` [dpdk-dev] [PATCH v3 02/21] bus/fslmc: introducing fsl-mc bus driver Hemant Agrawal
2017-04-09 7:50 ` [dpdk-dev] [PATCH v3 03/21] bus/fslmc: add QBMAN driver to bus Hemant Agrawal
2017-04-09 7:50 ` [dpdk-dev] [PATCH v3 04/21] bus/fslmc: introduce MC object functions Hemant Agrawal
2017-04-09 7:50 ` [dpdk-dev] [PATCH v3 05/21] bus/fslmc: add mc dpio object support Hemant Agrawal
2017-04-09 7:50 ` [dpdk-dev] [PATCH v3 06/21] bus/fslmc: add mc dpbp " Hemant Agrawal
2017-04-09 7:50 ` [dpdk-dev] [PATCH v3 07/21] eal/vfio: adding vfio utility functions in map file Hemant Agrawal
2017-04-09 7:50 ` [dpdk-dev] [PATCH v3 08/21] bus/fslmc: add vfio support Hemant Agrawal
2017-04-09 7:50 ` [dpdk-dev] [PATCH v3 09/21] bus/fslmc: scan for net and sec device Hemant Agrawal
2017-04-09 7:50 ` [dpdk-dev] [PATCH v3 10/21] bus/fslmc: add debug log support Hemant Agrawal
2017-04-09 7:50 ` [dpdk-dev] [PATCH v3 11/21] bus/fslmc: dpio portal driver Hemant Agrawal
2017-04-09 7:50 ` [dpdk-dev] [PATCH v3 12/21] bus/fslmc: introduce support for hardware mempool object Hemant Agrawal
2017-04-09 7:50 ` [dpdk-dev] [PATCH v3 13/21] bus/fslmc: affine dpio to crypto threads Hemant Agrawal
2017-04-09 7:50 ` [dpdk-dev] [PATCH v3 14/21] bus/fslmc: define queues for DPAA2 devices Hemant Agrawal
2017-04-09 7:50 ` [dpdk-dev] [PATCH v3 15/21] bus/fslmc: define hardware annotation area size Hemant Agrawal
2017-04-09 7:50 ` [dpdk-dev] [PATCH v3 16/21] bus/fslmc: introduce true and false macros Hemant Agrawal
2017-04-09 7:50 ` [dpdk-dev] [PATCH v3 17/21] bus/fslmc: define VLAN header length Hemant Agrawal
2017-04-09 7:50 ` [dpdk-dev] [PATCH v3 18/21] bus/fslmc: add packet FLE definitions Hemant Agrawal
2017-04-09 7:50 ` [dpdk-dev] [PATCH v3 19/21] bus/fslmc: add physical-virtual address translation helpers Hemant Agrawal
2017-04-09 7:50 ` [dpdk-dev] [PATCH v3 20/21] bus/fslmc: add support for DMA mapping for ARM SMMU Hemant Agrawal
2017-04-09 7:50 ` [dpdk-dev] [PATCH v3 21/21] bus/fslmc: frame queue based dq storage alloc Hemant Agrawal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=346d87ec-b57c-bc80-68b6-4ac9f76d48da@nxp.com \
--to=hemant.agrawal@nxp.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=olivier.matz@6wind.com \
--cc=shreyansh.jain@nxp.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).