From: Ferruh Yigit <ferruh.yigit@intel.com>
To: dev@dpdk.org
Cc: Thomas Monjalon <thomas@monjalon.net>,
dpdk-techboard <techboard@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/2] kni: fix build for 5.0 for dev_open()
Date: Tue, 22 Jan 2019 16:59:27 +0000 [thread overview]
Message-ID: <34834d92-8258-97b6-c7b2-2821b679452d@intel.com> (raw)
In-Reply-To: <20190122154429.41882-1-ferruh.yigit@intel.com>
On 1/22/2019 3:44 PM, Ferruh Yigit wrote:
> Build error seen with Linux kernel 5.0 and
> when CONFIG_RTE_KNI_KMOD_ETHTOOL is enabled.
>
> build error:
> .../build/build/kernel/linux/kni/ixgbe_ethtool.c:1746:4:
> error: too few arguments to function ‘dev_open’
> dev_open(netdev);
> ^~~~~~~~
> In file included from .../build/kernel/linux/kni/ixgbe_ethtool.c:18:
> .../linux/linux/include/linux/netdevice.h:2620:5: note: declared here
> int dev_open(struct net_device *dev, struct netlink_ext_ack *extack);
> ^~~~~~~~
>
> .../build/build/kernel/linux/kni/igb_ethtool.c:1812:4:
> error: too few arguments to function ‘dev_open’
> dev_open(netdev);
> ^~~~~~~~
> In file included from .../build/build/kernel/linux/kni/igb_ethtool.c:15:
> .../linux/linux/include/linux/netdevice.h:2620:5: note: declared here
> int dev_open(struct net_device *dev, struct netlink_ext_ack *extack);
> ^~~~~~~~
>
> dev_open() is changed in Linux kernel version 5.0 and now requires
> a new parameter, 'struct netlink_ext_ack *extack'.
> Fixed by defining dev_open as macro when kernel version >= 5.0
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Off the topic.
This is the patch 50000 in patchwork! This is a big number.
Thanks everyone contributed!
https://patches.dpdk.org/patch/50000/
The historical numbers from DPDK patchwork:
50000 - Jan. 22, 2019 (253 days) [ 8 months, 8 days / 36 weeks and 1 day ]
40000 - May. 14, 2018 (217 days)
30000 - Oct. 9, 2017 (258 days)
20000 - Jan. 25, 2017 (372 days)
10000 - Jan. 20, 2016 (645 days)
00001 - April 16, 2014
This is the first time DPDK patch pace slowed down (slightly), I guess this is
because of the holidays in the middle and small 19.02, but I think next
milestone which includes 19.05 will clarify this.
next prev parent reply other threads:[~2019-01-22 16:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-22 15:44 Ferruh Yigit
2019-01-22 15:44 ` [dpdk-dev] [PATCH 2/2] kni: fix build for 5.0 for igb_ndo_bridge_setlink() Ferruh Yigit
2019-01-22 16:59 ` Ferruh Yigit [this message]
2019-01-23 21:39 ` [dpdk-dev] [PATCH 1/2] kni: fix build for 5.0 for dev_open() Thomas Monjalon
2019-01-24 8:35 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34834d92-8258-97b6-c7b2-2821b679452d@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=techboard@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).