From: "Trahe, Fiona" <fiona.trahe@intel.com>
To: "akhil.goyal@nxp.com" <akhil.goyal@nxp.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Gonzalez Monroy, Sergio" <sergio.gonzalez.monroy@intel.com>,
"Doherty, Declan" <declan.doherty@intel.com>,
"De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
"Trahe, Fiona" <fiona.trahe@intel.com>
Subject: Re: [dpdk-dev] [PATCH 1/2] cryptodev: add api for attach-detach session with queue pair
Date: Mon, 20 Mar 2017 16:26:41 +0000 [thread overview]
Message-ID: <348A99DA5F5B7549AA880327E580B435891A9111@IRSMSX101.ger.corp.intel.com> (raw)
In-Reply-To: <20170317084510.2120-1-akhil.goyal@nxp.com>
Hi Akhil,
> -----Original Message-----
> From: akhil.goyal@nxp.com [mailto:akhil.goyal@nxp.com]
> Sent: Friday, March 17, 2017 8:45 AM
> To: dev@dpdk.org
> Cc: Gonzalez Monroy, Sergio <sergio.gonzalez.monroy@intel.com>; Doherty,
> Declan <declan.doherty@intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>; Trahe, Fiona <fiona.trahe@intel.com>;
> Akhil Goyal <akhil.goyal@nxp.com>
> Subject: [PATCH 1/2] cryptodev: add api for attach-detach session with queue
> pair
>
> From: Akhil Goyal <akhil.goyal@nxp.com>
>
> HW based crypto drivers may only support limited number of
> sessions per queue pair. This requires support for attaching
> sessions to specific queue pair. New APIs are introduced to
> attach/detach a session with/from a particular queue pair.
> These are optional APIs.
>
> Application can call attach API after creating a session
> and can call detach API before deleting a session.
>
> Application needs to check if max_nb_sessions_per_qp > 0,
> then it should call the attach API.
>
> max_nb_sessions_per_qp = 0 means infinite sessions per qp
>
> Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
> ---
> lib/librte_cryptodev/rte_cryptodev.c | 41
> ++++++++++++++++++++++++++
> lib/librte_cryptodev/rte_cryptodev.h | 27 +++++++++++++++++
> lib/librte_cryptodev/rte_cryptodev_pmd.h | 29 ++++++++++++++++++
> lib/librte_cryptodev/rte_cryptodev_version.map | 2 ++
> 4 files changed, 99 insertions(+)
>
> diff --git a/lib/librte_cryptodev/rte_cryptodev.c
> b/lib/librte_cryptodev/rte_cryptodev.c
> index 0ac23ed..f1eabd0 100644
> --- a/lib/librte_cryptodev/rte_cryptodev.c
> +++ b/lib/librte_cryptodev/rte_cryptodev.c
> @@ -1393,6 +1393,47 @@ rte_cryptodev_sym_session_create(uint8_t
> dev_id,
> return sess;
> }
>
> +void
> +rte_cryptodev_queue_pair_attach_sym_session(uint16_t qp_id,
> + struct rte_cryptodev_sym_session *sess)
> +{
> + struct rte_cryptodev *dev;
> +
> + if (!rte_cryptodev_pmd_is_valid_dev(sess->dev_id)) {
> + CDEV_LOG_ERR("Invalid dev_id=%d", sess->dev_id);
> + return;
> + }
> +
> + dev = &rte_crypto_devices[sess->dev_id];
> +
> + RTE_FUNC_PTR_OR_RET(*dev->dev_ops->qp_attach_session);
> + if (dev->dev_ops->qp_attach_session(dev, qp_id, sess->_private)) {
> + CDEV_LOG_ERR("dev_id %d failed to attach qp: %d with
> session",
> + sess->dev_id, qp_id);
> + return;
> + }
> +}
Wouldn't it be better if this returned an error if e.g. the qp already has max num sessions attached?
> +
> +void
> +rte_cryptodev_queue_pair_detach_sym_session(uint16_t qp_id,
> + struct rte_cryptodev_sym_session *sess)
> +{
> + struct rte_cryptodev *dev;
> +
> + if (!rte_cryptodev_pmd_is_valid_dev(sess->dev_id)) {
> + CDEV_LOG_ERR("Invalid dev_id=%d", sess->dev_id);
> + return;
> + }
> +
> + dev = &rte_crypto_devices[sess->dev_id];
> +
> + RTE_FUNC_PTR_OR_RET(*dev->dev_ops->qp_detach_session);
> + if (dev->dev_ops->qp_detach_session(dev, qp_id, sess->_private)) {
> + CDEV_LOG_ERR("dev_id %d failed to detach qp: %d from
> session",
> + sess->dev_id, qp_id);
> + return;
> + }
> +}
> struct rte_cryptodev_sym_session *
> rte_cryptodev_sym_session_free(uint8_t dev_id,
> struct rte_cryptodev_sym_session *sess)
> diff --git a/lib/librte_cryptodev/rte_cryptodev.h
> b/lib/librte_cryptodev/rte_cryptodev.h
> index d61a43e..b322bea 100644
> --- a/lib/librte_cryptodev/rte_cryptodev.h
> +++ b/lib/librte_cryptodev/rte_cryptodev.h
> @@ -332,6 +332,9 @@ struct rte_cryptodev_info {
> struct {
> unsigned max_nb_sessions;
> /**< Maximum number of sessions supported by device. */
> + unsigned max_nb_sessions_per_qp;
> + /**< Maximum number of sessions per queue pair.
> + * Default 0 for infinite sessions. */
> } sym;
> };
>
> @@ -915,6 +918,30 @@ extern struct rte_cryptodev_sym_session *
> rte_cryptodev_sym_session_free(uint8_t dev_id,
> struct rte_cryptodev_sym_session *session);
>
> +/**
> + * Attach queue pair with sym session.
> + *
> + * @param qp_id Queue pair to which session will be attached.
> + * @param session Session pointer previously allocated by
> + * *rte_cryptodev_sym_session_create*.
> + *
> + */
> +extern void
> +rte_cryptodev_queue_pair_attach_sym_session(uint16_t qp_id,
> + struct rte_cryptodev_sym_session *session);
> +
> +/**
> + * Detach queue pair with sym session.
> + *
> + * @param qp_id Queue pair to which session is attached.
> + * @param session Session pointer previously allocated by
> + * *rte_cryptodev_sym_session_create*.
> + *
> + */
> +extern void
> +rte_cryptodev_queue_pair_detach_sym_session(uint16_t qp_id,
> + struct rte_cryptodev_sym_session *session);
> +
>
> #ifdef __cplusplus
> }
> diff --git a/lib/librte_cryptodev/rte_cryptodev_pmd.h
> b/lib/librte_cryptodev/rte_cryptodev_pmd.h
> index 1a417e2..df92817 100644
> --- a/lib/librte_cryptodev/rte_cryptodev_pmd.h
> +++ b/lib/librte_cryptodev/rte_cryptodev_pmd.h
> @@ -381,6 +381,31 @@ typedef void *
> (*cryptodev_sym_configure_session_t)(struct rte_cryptodev *dev,
> typedef void (*cryptodev_sym_free_session_t)(struct rte_cryptodev *dev,
> void *session_private);
>
> +/**
> + * Optional API for drivers to attach sessions with queue pair.
> + * @param dev Crypto device pointer
> + * @param qp_id queue pair id for attaching session
> + * @param priv_sess Pointer to cryptodev's private session structure
> + * @return
> + * - Return 0 on success
> + */
> +typedef int (*cryptodev_sym_queue_pair_attach_session_t)(
> + struct rte_cryptodev *dev,
> + uint16_t qp_id,
> + void *session_private);
> +
> +/**
> + * Optional API for drivers to detach sessions from queue pair.
> + * @param dev Crypto device pointer
> + * @param qp_id queue pair id for detaching session
> + * @param priv_sess Pointer to cryptodev's private session structure
> + * @return
> + * - Return 0 on success
> + */
> +typedef int (*cryptodev_sym_queue_pair_detach_session_t)(
> + struct rte_cryptodev *dev,
> + uint16_t qp_id,
> + void *session_private);
>
> /** Crypto device operations function pointer table */
> struct rte_cryptodev_ops {
> @@ -415,6 +440,10 @@ struct rte_cryptodev_ops {
> /**< Configure a Crypto session. */
> cryptodev_sym_free_session_t session_clear;
> /**< Clear a Crypto sessions private data. */
> + cryptodev_sym_queue_pair_attach_session_t qp_attach_session;
> + /**< Attach queue pair with session. */
> + cryptodev_sym_queue_pair_attach_session_t qp_detach_session;
> + /**< Detach queue pair from session. */
> };
>
>
> diff --git a/lib/librte_cryptodev/rte_cryptodev_version.map
> b/lib/librte_cryptodev/rte_cryptodev_version.map
> index 831a15c..9ac510e 100644
> --- a/lib/librte_cryptodev/rte_cryptodev_version.map
> +++ b/lib/librte_cryptodev/rte_cryptodev_version.map
> @@ -70,5 +70,7 @@ DPDK_17.05 {
>
> rte_cryptodev_get_auth_algo_enum;
> rte_cryptodev_get_cipher_algo_enum;
> + rte_cryptodev_queue_pair_attach_sym_session;
> + rte_cryptodev_queue_pair_detach_sym_session;
>
> } DPDK_17.02;
> --
> 2.9.3
next prev parent reply other threads:[~2017-03-20 16:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-17 8:45 akhil.goyal
2017-03-17 8:45 ` [dpdk-dev] [PATCH 2/2] examples/ipsec-secgw: attach session-qp akhil.goyal
2017-03-20 16:26 ` Trahe, Fiona [this message]
2017-03-21 5:31 ` [dpdk-dev] [PATCH 1/2] cryptodev: add api for attach-detach session with queue pair Akhil Goyal
2017-03-23 8:06 ` [dpdk-dev] [PATCH v2 " akhil.goyal
2017-03-23 8:06 ` [dpdk-dev] [PATCH v2 2/2] examples/ipsec-secgw: attach session-qp akhil.goyal
2017-03-23 10:30 ` Sergio Gonzalez Monroy
2017-03-23 10:38 ` Akhil Goyal
2017-03-23 10:43 ` Sergio Gonzalez Monroy
2017-03-23 12:18 ` Akhil Goyal
2017-03-23 14:37 ` [dpdk-dev] [PATCH v2 1/2] cryptodev: add api for attach-detach session with queue pair Trahe, Fiona
2017-03-24 9:29 ` [dpdk-dev] [PATCH v3 " akhil.goyal
2017-03-24 9:29 ` [dpdk-dev] [PATCH v3 2/2] examples/ipsec-secgw: attach session-qp akhil.goyal
2017-03-28 12:58 ` De Lara Guarch, Pablo
2017-03-28 12:58 ` [dpdk-dev] [PATCH v3 1/2] cryptodev: add api for attach-detach session with queue pair De Lara Guarch, Pablo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=348A99DA5F5B7549AA880327E580B435891A9111@IRSMSX101.ger.corp.intel.com \
--to=fiona.trahe@intel.com \
--cc=akhil.goyal@nxp.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
--cc=sergio.gonzalez.monroy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).