From: "Trahe, Fiona" <fiona.trahe@intel.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
"Doherty, Declan" <declan.doherty@intel.com>,
"Jain, Deepak K" <deepak.k.jain@intel.com>,
"Griffin, John" <john.griffin@intel.com>,
"Kusztal, ArkadiuszX" <arkadiuszx.kusztal@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] cryptodev: fix KASUMI F9 expected parameters
Date: Fri, 14 Jul 2017 16:16:50 +0000 [thread overview]
Message-ID: <348A99DA5F5B7549AA880327E580B435892366A4@IRSMSX101.ger.corp.intel.com> (raw)
In-Reply-To: <20170714070652.54494-1-pablo.de.lara.guarch@intel.com>
Hi Pablo,
> -----Original Message-----
> From: Trahe, Fiona
> Sent: Friday, July 14, 2017 4:48 PM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Doherty, Declan
> <declan.doherty@intel.com>; Jain, Deepak K <deepak.k.jain@intel.com>; Griffin, John
> <john.griffin@intel.com>; Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>
> Cc: dev@dpdk.org
> Subject: RE: [PATCH v2] cryptodev: fix KASUMI F9 expected parameters
>
>
>
> > -----Original Message-----
> > From: De Lara Guarch, Pablo
> > Sent: Friday, July 14, 2017 8:07 AM
> > To: Doherty, Declan <declan.doherty@intel.com>; Trahe, Fiona <fiona.trahe@intel.com>; Jain, Deepak
> K
> > <deepak.k.jain@intel.com>; Griffin, John <john.griffin@intel.com>; Kusztal, ArkadiuszX
> > <arkadiuszx.kusztal@intel.com>
> > Cc: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> > Subject: [PATCH v2] cryptodev: fix KASUMI F9 expected parameters
> >
> > For KASUMI F9 algorithm, COUNT, FRESH and DIRECTION
> > input values need to be contiguous with
> > the message, as described in the KASUMI and QAT PMD
> > documentation.
> >
> > Before, the COUNT and FRESH values were set
> > as part of the AAD (now IV), but always set before
> > the beginning of the message.
> > Since now the IV is set after the crypto operation,
> > it is not possible to have these values in the
> > expected location.
> >
> > Therefore, as these are required to be contiguous,
> > cryptodev API will expect these them to be passed
> > as a single buffer, already constructed, so
> > authentication IV parameters not needed anymore.
> >
> > Fixes: 681f540da52b ("cryptodev: do not use AAD in wireless algorithms")
> >
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> Acked-by: Fiona Trahe <fiona.trahe@intel.com>
The limitation in QAT documentation stating that Kasumi F9 auth_len and auth_offset must be byte-multiples can be removed as this is now a limitation on the API, not on QAT.
next prev parent reply other threads:[~2017-07-14 16:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-13 7:44 [dpdk-dev] [PATCH] " Pablo de Lara
2017-07-14 7:06 ` [dpdk-dev] [PATCH v2] " Pablo de Lara
2017-07-14 15:47 ` Trahe, Fiona
2017-07-14 16:16 ` Trahe, Fiona [this message]
2017-07-16 10:57 ` De Lara Guarch, Pablo
2017-07-14 9:31 ` [dpdk-dev] [PATCH] " Trahe, Fiona
2017-07-14 10:30 ` De Lara Guarch, Pablo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=348A99DA5F5B7549AA880327E580B435892366A4@IRSMSX101.ger.corp.intel.com \
--to=fiona.trahe@intel.com \
--cc=arkadiuszx.kusztal@intel.com \
--cc=declan.doherty@intel.com \
--cc=deepak.k.jain@intel.com \
--cc=dev@dpdk.org \
--cc=john.griffin@intel.com \
--cc=pablo.de.lara.guarch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).