From: "Trahe, Fiona" <fiona.trahe@intel.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
"Jain, Deepak K" <deepak.k.jain@intel.com>,
"Griffin, John" <john.griffin@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Trahe, Fiona" <fiona.trahe@intel.com>
Subject: Re: [dpdk-dev] [PATCH] crypto/qat: fix session initialization
Date: Wed, 19 Jul 2017 14:06:04 +0000 [thread overview]
Message-ID: <348A99DA5F5B7549AA880327E580B435892389FC@IRSMSX101.ger.corp.intel.com> (raw)
In-Reply-To: <20170719045902.12110-1-pablo.de.lara.guarch@intel.com>
> -----Original Message-----
> From: De Lara Guarch, Pablo
> Sent: Wednesday, July 19, 2017 5:59 AM
> To: Trahe, Fiona <fiona.trahe@intel.com>; Jain, Deepak K <deepak.k.jain@intel.com>; Griffin, John
> <john.griffin@intel.com>
> Cc: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Subject: [PATCH] crypto/qat: fix session initialization
>
> When creating a session, if there is a failure when
> setting some of the parameters, QAT was not propagating
> the error to the session initialization function.
> Therefore, it was reporting a success, when it should
> be report a failure.
>
> Fixes: b3bbd9e5f265 ("cryptodev: support device independent sessions")
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
In the 3 fn prototypes in qat_crypto.h it would be nice to remove the _private from
struct qat_session *session_private. Apart from that it's fine.
Acked-by: Fiona Trahe <iona.trahe@intel.com>
next prev parent reply other threads:[~2017-07-19 14:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-19 4:59 Pablo de Lara
2017-07-19 14:06 ` Trahe, Fiona [this message]
2017-07-19 14:37 ` De Lara Guarch, Pablo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=348A99DA5F5B7549AA880327E580B435892389FC@IRSMSX101.ger.corp.intel.com \
--to=fiona.trahe@intel.com \
--cc=deepak.k.jain@intel.com \
--cc=dev@dpdk.org \
--cc=john.griffin@intel.com \
--cc=pablo.de.lara.guarch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).