DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Trahe, Fiona" <fiona.trahe@intel.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
	"ashish.gupta@caviumnetworks.com"
	<ashish.gupta@caviumnetworks.com>,
	"Daly, Lee" <lee.daly@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Trahe, Fiona" <fiona.trahe@intel.com>
Subject: Re: [dpdk-dev] [PATCH 2/2] compressdev: add huffman encoding flags
Date: Wed, 27 Jun 2018 17:35:07 +0000	[thread overview]
Message-ID: <348A99DA5F5B7549AA880327E580B435895B6052@IRSMSX101.ger.corp.intel.com> (raw)
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8977F8DDC5A@IRSMSX108.ger.corp.intel.com>

> > > +	case RTE_COMP_FF_HUFFMAN_FIXED:
> > > +		return "HUFFMAN_FIXED";
> > > +	case RTE_COMP_FF_HUFFMAN_DYNAMIC:
> > > +		return "HUFFMAN_DYNAMIC";
> > [Fiona] Thanks for adding this.
> > Just in case any other algos are added in future which also use Huffman
> > encoding I'd suggest renaming to include DEFLATE, e.g.
> > RTE_COMP_FF_DFL_HUFFMAN_FIXED/DYNAMIC
> 
> Since these flags are set per algorithm (in capabilities),
> do you think it is needed to specify DEFLATE?
> 
[Fiona] You're right, I forgot that. So better not to include DEFLATE. 

  reply	other threads:[~2018-06-27 17:35 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-27  5:50 [dpdk-dev] [PATCH 1/2] compressdev: replace mbuf scatter gather flag Pablo de Lara
2018-06-27  5:50 ` [dpdk-dev] [PATCH 2/2] compressdev: add huffman encoding flags Pablo de Lara
2018-06-27 15:22   ` Trahe, Fiona
2018-06-27 15:36     ` De Lara Guarch, Pablo
2018-06-27 17:35       ` Trahe, Fiona [this message]
2018-06-28 10:00   ` Daly, Lee
2018-06-27 12:16 ` [dpdk-dev] [PATCH v2 1/2] compressdev: replace mbuf scatter gather flag Pablo de Lara
2018-06-27 12:16   ` [dpdk-dev] [PATCH v2 2/2] compressdev: add huffman encoding flags Pablo de Lara
2018-06-28  7:49     ` Trahe, Fiona
2018-06-28  7:48   ` [dpdk-dev] [PATCH v2 1/2] compressdev: replace mbuf scatter gather flag Trahe, Fiona
2018-06-29 10:08   ` Trahe, Fiona
2018-06-27 15:14 ` [dpdk-dev] [PATCH " Trahe, Fiona
2018-06-27 15:33   ` De Lara Guarch, Pablo
2018-07-04 14:10 ` [dpdk-dev] [PATCH v3 1/4] doc: cleanup ISA-L PMD feature matrix Pablo de Lara
2018-07-04 14:10   ` [dpdk-dev] [PATCH v3 2/4] doc: rename compress feature flag Pablo de Lara
2018-07-05  2:41     ` Verma, Shally
2018-07-05 11:03       ` De Lara Guarch, Pablo
2018-07-05  8:07     ` Trahe, Fiona
2018-07-04 14:10   ` [dpdk-dev] [PATCH v3 3/4] compressdev: replace mbuf scatter gather flag Pablo de Lara
2018-07-05  8:38     ` Verma, Shally
2018-07-05 11:05       ` De Lara Guarch, Pablo
2018-07-05 11:12         ` Verma, Shally
2018-07-05 11:25           ` De Lara Guarch, Pablo
2018-07-05 11:58             ` Verma, Shally
2018-07-06  8:40               ` De Lara Guarch, Pablo
2018-07-06  8:53                 ` Verma, Shally
2018-07-06  8:59                   ` De Lara Guarch, Pablo
2018-07-04 14:10   ` [dpdk-dev] [PATCH v3 4/4] compressdev: add huffman encoding flags Pablo de Lara
2018-07-05  8:14     ` Verma, Shally
2018-07-05 11:21       ` De Lara Guarch, Pablo
2018-07-05  8:10   ` [dpdk-dev] [PATCH v3 1/4] doc: cleanup ISA-L PMD feature matrix Daly, Lee
2018-07-06  2:54 ` [dpdk-dev] [PATCH v4 " Pablo de Lara
2018-07-06  2:54   ` [dpdk-dev] [PATCH v4 2/4] doc: rename compress feature flag Pablo de Lara
2018-07-06 12:17     ` Verma, Shally
2018-07-06  2:54   ` [dpdk-dev] [PATCH v4 3/4] compressdev: replace mbuf scatter gather flag Pablo de Lara
2018-07-06 12:33     ` Verma, Shally
2018-07-06  2:54   ` [dpdk-dev] [PATCH v4 4/4] compressdev: add huffman encoding flags Pablo de Lara
2018-07-06  5:27 ` [dpdk-dev] [PATCH v5 1/4] doc: cleanup ISA-L PMD feature matrix Pablo de Lara
2018-07-06  5:27   ` [dpdk-dev] [PATCH v5 2/4] doc: rename compress feature flag Pablo de Lara
2018-07-06  5:28   ` [dpdk-dev] [PATCH v5 3/4] compressdev: replace mbuf scatter gather flag Pablo de Lara
2018-07-07  6:34     ` Verma, Shally
2018-07-09  8:07       ` De Lara Guarch, Pablo
2018-07-06  5:28   ` [dpdk-dev] [PATCH v5 4/4] compressdev: add huffman encoding flags Pablo de Lara
2018-07-07  6:36     ` Verma, Shally
2018-07-09  8:11   ` [dpdk-dev] [PATCH v5 1/4] doc: cleanup ISA-L PMD feature matrix De Lara Guarch, Pablo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=348A99DA5F5B7549AA880327E580B435895B6052@IRSMSX101.ger.corp.intel.com \
    --to=fiona.trahe@intel.com \
    --cc=ashish.gupta@caviumnetworks.com \
    --cc=dev@dpdk.org \
    --cc=lee.daly@intel.com \
    --cc=pablo.de.lara.guarch@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).