From: "Trahe, Fiona" <fiona.trahe@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
"Jozwiak, TomaszX" <tomaszx.jozwiak@intel.com>,
"Trahe, Fiona" <fiona.trahe@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2 0/8] doc/qat: clarify build config options
Date: Fri, 10 Aug 2018 07:57:31 +0000 [thread overview]
Message-ID: <348A99DA5F5B7549AA880327E580B43589600030@IRSMSX101.ger.corp.intel.com> (raw)
In-Reply-To: <1733267.56J5JmrzPi@xps>
Hi Thomas
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Thursday, August 9, 2018 8:49 PM
> To: Trahe, Fiona <fiona.trahe@intel.com>
> Cc: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Jozwiak, TomaszX
> <tomaszx.jozwiak@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v2 0/8] doc/qat: clarify build config options
>
> 09/08/2018 18:50, Fiona Trahe:
> > Clarified documentation structure between
> > compressedev, cryptodev and common build parts.
> > Clarified build configuration options.
> > Added Testing section.
> > Fixed typos and made some cosmetic improvements.
> >
> > v2 changes
> > - split into patchset
>
> I am not sure about the split.
> Usually, when there is no text in the commit log,
> it is a tip that it is not worth to be a separate commit.
> Perhaps, it is good to have this split, but in this case,
> please try to explain the purpose (or reason) of each patch in the commit logs.
>
> Thanks
>
With over 200 changed lines in the v1 patch I did this to make it easier for Pablo to review.
I'll add more explanation in the v3.
next prev parent reply other threads:[~2018-08-10 7:58 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-09 13:17 [dpdk-dev] [PATCH] " Fiona Trahe
2018-08-09 16:50 ` [dpdk-dev] [PATCH v2 0/8] " Fiona Trahe
2018-08-09 17:08 ` De Lara Guarch, Pablo
2018-08-09 19:49 ` Thomas Monjalon
2018-08-10 7:57 ` Trahe, Fiona [this message]
2018-08-09 16:50 ` [dpdk-dev] [PATCH v2 1/8] doc/qat: add limitations to compressdev PMD Fiona Trahe
2018-08-09 16:50 ` [dpdk-dev] [PATCH v2 2/8] doc/qat: add information on how to test Fiona Trahe
2018-08-09 16:50 ` [dpdk-dev] [PATCH v2 3/8] doc/qat: fix typos and make cosmetic changes Fiona Trahe
2018-08-09 16:50 ` [dpdk-dev] [PATCH v2 4/8] doc/qat: add overview of doc sections Fiona Trahe
2018-08-09 16:50 ` [dpdk-dev] [PATCH v2 5/8] doc/qat: remove unnecessary text Fiona Trahe
2018-08-09 16:50 ` [dpdk-dev] [PATCH v2 6/8] doc/qat: update kernel dependency section Fiona Trahe
2018-08-09 19:36 ` Thomas Monjalon
2018-08-10 7:45 ` Trahe, Fiona
2018-08-09 16:50 ` [dpdk-dev] [PATCH v2 7/8] doc/qat: update PMD build section Fiona Trahe
2018-08-09 19:47 ` Thomas Monjalon
2018-08-10 7:51 ` Trahe, Fiona
2018-08-10 9:00 ` Thomas Monjalon
2018-08-10 13:14 ` Trahe, Fiona
2018-08-10 14:10 ` [dpdk-dev] [PATCH v3 0/6] doc/qat: clarify build config options Fiona Trahe
2018-08-13 14:51 ` Jozwiak, TomaszX
2018-08-23 11:12 ` Akhil Goyal
2018-08-23 11:24 ` Thomas Monjalon
2018-08-23 11:28 ` Akhil Goyal
2018-08-23 11:35 ` Thomas Monjalon
2018-08-10 14:10 ` [dpdk-dev] [PATCH v3 1/6] doc/qat: add limitations to compressdev PMD Fiona Trahe
2018-08-13 14:31 ` Jozwiak, TomaszX
2018-08-10 14:10 ` [dpdk-dev] [PATCH v3 2/6] doc/qat: add information on how to test Fiona Trahe
2018-08-13 14:32 ` Jozwiak, TomaszX
2018-08-10 14:10 ` [dpdk-dev] [PATCH v3 3/6] doc/qat: fix typos and make cosmetic changes Fiona Trahe
2018-08-13 14:33 ` Jozwiak, TomaszX
2018-08-10 14:10 ` [dpdk-dev] [PATCH v3 4/6] doc/qat: add overview of doc sections Fiona Trahe
2018-08-13 14:37 ` Jozwiak, TomaszX
2018-08-10 14:10 ` [dpdk-dev] [PATCH v3 5/6] doc/qat: update build instructions for both PMDs Fiona Trahe
2018-08-13 14:37 ` Jozwiak, TomaszX
2018-08-10 14:10 ` [dpdk-dev] [PATCH v3 6/6] doc/qat: describe build config options Fiona Trahe
2018-08-13 14:38 ` Jozwiak, TomaszX
2018-08-09 16:50 ` [dpdk-dev] [PATCH v2] " Fiona Trahe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=348A99DA5F5B7549AA880327E580B43589600030@IRSMSX101.ger.corp.intel.com \
--to=fiona.trahe@intel.com \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
--cc=thomas@monjalon.net \
--cc=tomaszx.jozwiak@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).