DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Trahe, Fiona" <fiona.trahe@intel.com>
To: "Kusztal, ArkadiuszX" <arkadiuszx.kusztal@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: "akhil.goyal@nxp.com" <akhil.goyal@nxp.com>,
	"Trahe, Fiona" <fiona.trahe@intel.com>
Subject: Re: [dpdk-dev] [PATCH v4 2/4] crypto/qat: add asymmetric cryptography PMD
Date: Wed, 27 Mar 2019 18:19:04 +0000	[thread overview]
Message-ID: <348A99DA5F5B7549AA880327E580B4358972086A@IRSMSX101.ger.corp.intel.com> (raw)
In-Reply-To: <20190327111720.13732-3-arkadiuszx.kusztal@intel.com>

Hi Arek,

> -----Original Message-----
> From: Kusztal, ArkadiuszX
> Sent: Wednesday, March 27, 2019 11:17 AM
> To: dev@dpdk.org
> Cc: akhil.goyal@nxp.com; Trahe, Fiona <fiona.trahe@intel.com>; Kusztal, ArkadiuszX
> <arkadiuszx.kusztal@intel.com>
> Subject: [PATCH v4 2/4] crypto/qat: add asymmetric cryptography PMD
> 
> This patch adds Poll Mode Driver for asymmetric crypto
> functions of Intel QuickAssist Technology hardware.
> 
> It contains plain driver with no functions implmented, specific
> algorithms will be introduced in separate patches.
> 
> This patch depends on a QAT PF driver for device initialization. See
> the file docs/guides/cryptodevs/qat.rst for configuration details.
> 
> Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
//snip///

> +void
> +qat_asym_process_response(void **op, uint8_t *resp,
> +		void *op_cookie)
> +{
> +	struct icp_qat_fw_pke_resp *resp_msg =
> +			(struct icp_qat_fw_pke_resp *)resp;
> +	struct rte_crypto_op *rx_op = (struct rte_crypto_op *)(uintptr_t)
> +			(resp_msg->opaque);
> +	struct qat_asym_op_cookie *cookie = op_cookie;
> +
> +	*op = rx_op;
> +	rx_op->status = RTE_CRYPTO_OP_STATUS_NOT_PROCESSED;
> +
[Fiona] Need to check for response_type == NULL - don't use the resp_status field in this case - get the error from the cookie instead.

  parent reply	other threads:[~2019-03-27 18:19 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-27 11:17 [dpdk-dev] [PATCH v4 0/4] Add PMD for asymmetric cryptography operations using Intel QuickAssist Technology devices Arek Kusztal
2019-03-27 11:17 ` Arek Kusztal
2019-03-27 11:17 ` [dpdk-dev] [PATCH v4 1/4] common/qat: add headers for asymmetric crypto Arek Kusztal
2019-03-27 11:17   ` Arek Kusztal
2019-03-27 11:17 ` [dpdk-dev] [PATCH v4 2/4] crypto/qat: add asymmetric cryptography PMD Arek Kusztal
2019-03-27 11:17   ` Arek Kusztal
2019-03-27 18:19   ` Trahe, Fiona [this message]
2019-03-27 18:19     ` Trahe, Fiona
2019-03-27 11:17 ` [dpdk-dev] [PATCH v4 3/4] crypto/qat: add modular exponentiation to qat asym pmd Arek Kusztal
2019-03-27 11:17   ` Arek Kusztal
2019-03-27 11:17 ` [dpdk-dev] [PATCH v4 4/4] crypto/qat: add modular inverse " Arek Kusztal
2019-03-27 11:17   ` Arek Kusztal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=348A99DA5F5B7549AA880327E580B4358972086A@IRSMSX101.ger.corp.intel.com \
    --to=fiona.trahe@intel.com \
    --cc=akhil.goyal@nxp.com \
    --cc=arkadiuszx.kusztal@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).