From: "Trahe, Fiona" <fiona.trahe@intel.com>
To: Ayuj Verma <ayverma@marvell.com>,
"akhil.goyal@nxp.com" <akhil.goyal@nxp.com>,
"De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
"Kusztal, ArkadiuszX" <arkadiuszx.kusztal@intel.com>
Cc: Shally Verma <shallyv@marvell.com>,
Sunila Sahu <ssahu@marvell.com>,
Kanaka Durga Kotamarthy <kkotamarthy@marvell.com>,
Arvind Desai <adesai@marvell.com>, "dev@dpdk.org" <dev@dpdk.org>,
"Trahe, Fiona" <fiona.trahe@intel.com>
Subject: Re: [dpdk-dev] [PATCH v1] app/test: add check for tests skipped
Date: Wed, 3 Apr 2019 14:08:46 +0000 [thread overview]
Message-ID: <348A99DA5F5B7549AA880327E580B43589729A7B@IRSMSX101.ger.corp.intel.com> (raw)
In-Reply-To: <MN2PR18MB2542F672642BDD0F1DBF8B3DAD570@MN2PR18MB2542.namprd18.prod.outlook.com>
Hi Ayuj,
________________________________________
From: Ayuj Verma <ayverma@marvell.com>
Sent: 01 April 2019 13:01:56
To: akhil.goyal@nxp.com
Cc: arkadiuszx.kusztal@intel.com; Shally Verma; Sunila Sahu; Kanaka Durga Kotamarthy; Arvind Desai; dev@dpdk.org; Ayuj Verma
Subject: [PATCH v1] app/test: add check for tests skipped
Add skipped counter to count for number of skipped testcases.
Signed-off-by: Ayuj Verma <ayverma@marvell.com>
Signed-off-by: Shally Verma <shallyv@marvell.com>
---
app/test/test.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/app/test/test.c b/app/test/test.c
index d646f51..1e0113b 100644
--- a/app/test/test.c
+++ b/app/test/test.c
@@ -237,6 +237,8 @@
succeeded++;
else if (test_success == -ENOTSUP)
unsupported++;
+ else if (test_success == TEST_SKIPPED)
+ skipped++;
else
failed++;
} else if (test_success == -ENOTSUP) {
--
1.8.3.1
[Fiona] I just tried it out.
The patch itself is ok - it works if a test case at run-time decides to return TEST_SKIPPED.
A compile-time decision to skip a test-case can be made by using TEST_CASE_ST_DISABLED and this already counts as skipped.
But I see the 2 places you're using TEST_SKIPPED are where the device doesn't support the capability needed for the test. In other similar cases (e.g. sym_crypto ZUC test) -ENOTSUP is returned. This seems like a more appropriate return value.
So unless there's some other reason other than Unsupported that a run-time decision would be made to skip a test, I'd nack this patch as it leads to confusion about which value should be returned.
Fiona
next prev parent reply other threads:[~2019-04-03 14:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-01 7:31 [dpdk-dev] [PATCH v1] Add check for skipped tests Ayuj Verma
2019-04-01 7:31 ` Ayuj Verma
2019-04-01 7:31 ` [dpdk-dev] [PATCH v1] app/test: add check for tests skipped Ayuj Verma
2019-04-01 7:31 ` Ayuj Verma
2019-04-03 10:00 ` Ayuj Verma
2019-04-03 10:00 ` Ayuj Verma
2019-04-03 10:09 ` Ayuj Verma
2019-04-03 10:09 ` Ayuj Verma
2019-04-03 14:08 ` Trahe, Fiona [this message]
2019-04-03 14:08 ` Trahe, Fiona
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=348A99DA5F5B7549AA880327E580B43589729A7B@IRSMSX101.ger.corp.intel.com \
--to=fiona.trahe@intel.com \
--cc=adesai@marvell.com \
--cc=akhil.goyal@nxp.com \
--cc=arkadiuszx.kusztal@intel.com \
--cc=ayverma@marvell.com \
--cc=dev@dpdk.org \
--cc=kkotamarthy@marvell.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=shallyv@marvell.com \
--cc=ssahu@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).