From: "Trahe, Fiona" <fiona.trahe@intel.com>
To: "Kusztal, ArkadiuszX" <arkadiuszx.kusztal@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "akhil.goyal@nxp.com" <akhil.goyal@nxp.com>,
"shallyv@marvell.com" <shallyv@marvell.com>,
"Nowak, DamianX" <damianx.nowak@intel.com>,
"Trahe, Fiona" <fiona.trahe@intel.com>
Subject: Re: [dpdk-dev] [PATCH v4 00/11] Rework API for RSA algorithm in asymmetric crypto
Date: Wed, 17 Jul 2019 16:00:06 +0000 [thread overview]
Message-ID: <348A99DA5F5B7549AA880327E580B435897C6798@IRSMSX101.ger.corp.intel.com> (raw)
In-Reply-To: <20190717125111.11288-1-arkadiuszx.kusztal@intel.com>
> -----Original Message-----
> From: Kusztal, ArkadiuszX
> Sent: Wednesday, July 17, 2019 1:51 PM
> To: dev@dpdk.org
> Cc: akhil.goyal@nxp.com; Trahe, Fiona <fiona.trahe@intel.com>; shallyv@marvell.com; Nowak,
> DamianX <damianx.nowak@intel.com>; Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>
> Subject: [PATCH v4 00/11] Rework API for RSA algorithm in asymmetric crypto
>
> Split into smaller commits, in order from least disputable ones.
> Open things beside this:
> 1. Creating padding struct
> 2. Padding parameters (seedlen, optional label etc)
> 3. Leading zeroes questions.
> 4. Random number requirements.
> 5. Capabilities.
> 6. Verify signature field when none padding.
>
> v4:
> - change API comments from length -> array allocation
> to avoid ambiguity
>
> v3:
> - split into smaller patches
> - removed padding struct changes
> - rebased against patches from CRT patches from Ayuj Verma
>
> v2:
> - Field for singature verification when padding none selected was added
> - Removed details from RFC
> - Simplified padding struct
> - Added padding none test case
>
> This patchset depends on following patches:
> [1]
> test/crypto: move rsa enqueue/dequeue into separate functions
> (http://patchwork.dpdk.org/patch/56342/)
> [2]
> test/crypto: add tests for RSA key type CRT
> (http://patchwork.dpdk.org/patch/56343/)
>
> Arek Kusztal (11):
> cryptodev: change RSA API comments about primes
> cryptodev: add cipher field to RSA op
> crypto/openssl: add cipher field to openssl RSA implementation
> test: add cipher field to RSA test
> cryptodev: add information about message format when signing with RSA
> cryptodev: remove RSA PKCS1 BT0 padding
> openssl: remove RSA PKCS1_5 BT0 padding
> test: remove RSA PKCS1_5 BT0 padding from test cases
> cryptodev: add RSA padding none description
> test: add pkcs1_5 padding simulation
> test: add RSA PKCS1_5 padding case when no padding selected
>
> app/test/test_cryptodev_asym.c | 53 ++++++++++++++++++++------
> app/test/test_cryptodev_asym_util.h | 54 +++++++++++++++++++++++++++
> drivers/crypto/openssl/rte_openssl_pmd.c | 12 +++---
> lib/librte_cryptodev/rte_crypto_asym.h | 64 ++++++++++++++++++++++++--------
> 4 files changed, 149 insertions(+), 34 deletions(-)
>
> --
> 2.1.0
Series-acked-by: Fiona Trahe <fiona.trahe@intel.com>
next prev parent reply other threads:[~2019-07-17 16:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-17 12:51 Arek Kusztal
2019-07-17 12:51 ` [dpdk-dev] [PATCH v4 01/11] cryptodev: change RSA API comments about primes Arek Kusztal
2019-07-17 12:51 ` [dpdk-dev] [PATCH v4 02/11] cryptodev: add cipher field to RSA op Arek Kusztal
2019-07-17 12:51 ` [dpdk-dev] [PATCH v4 03/11] crypto/openssl: add cipher field to openssl RSA implementation Arek Kusztal
2019-07-17 12:51 ` [dpdk-dev] [PATCH v4 04/11] test: add cipher field to RSA test Arek Kusztal
2019-07-17 12:51 ` [dpdk-dev] [PATCH v4 05/11] cryptodev: add information about message format when signing with RSA Arek Kusztal
2019-07-17 12:51 ` [dpdk-dev] [PATCH v4 06/11] cryptodev: remove RSA PKCS1 BT0 padding Arek Kusztal
2019-07-17 12:51 ` [dpdk-dev] [PATCH v4 07/11] openssl: remove RSA PKCS1_5 " Arek Kusztal
2019-07-17 12:51 ` [dpdk-dev] [PATCH v4 08/11] test: remove RSA PKCS1_5 BT0 padding from test cases Arek Kusztal
2019-07-17 12:51 ` [dpdk-dev] [PATCH v4 09/11] cryptodev: add RSA padding none description Arek Kusztal
2019-07-17 12:51 ` [dpdk-dev] [PATCH v4 10/11] test: add pkcs1_5 padding simulation Arek Kusztal
2019-07-17 12:51 ` [dpdk-dev] [PATCH v4 11/11] test: add RSA PKCS1_5 padding case when no padding selected Arek Kusztal
2019-07-17 16:00 ` Trahe, Fiona [this message]
2019-07-18 8:57 ` [dpdk-dev] [PATCH v4 00/11] Rework API for RSA algorithm in asymmetric crypto Nowak, DamianX
2019-07-18 10:52 ` Shally Verma
2019-07-18 13:09 ` Kusztal, ArkadiuszX
2019-07-18 13:18 ` Shally Verma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=348A99DA5F5B7549AA880327E580B435897C6798@IRSMSX101.ger.corp.intel.com \
--to=fiona.trahe@intel.com \
--cc=akhil.goyal@nxp.com \
--cc=arkadiuszx.kusztal@intel.com \
--cc=damianx.nowak@intel.com \
--cc=dev@dpdk.org \
--cc=shallyv@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).