From: Thomas Monjalon <thomas@monjalon.net>
To: Hanumanth Pothula <hpothula@marvell.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Cc: Ferruh Yigit <ferruh.yigit@amd.com>, dev@dpdk.org
Subject: Re: [PATCH v8 0/4] ethdev: support mulitiple mbuf pools per Rx queue
Date: Sat, 08 Oct 2022 22:38:44 +0200 [thread overview]
Message-ID: <3499917.LM0AJKV5NW@thomas> (raw)
In-Reply-To: <20221007172921.3325250-1-andrew.rybchenko@oktetlabs.ru>
07/10/2022 19:29, Andrew Rybchenko:
> I'm not sure in testpmd patch. Review would be useful and may be we
> should postpone it to rc2.
>
> v8:
> - Process review notes
> v7:
> - Drop RTE_ETH_RX_OFFLOAD_MUL_MEMPOOL offload which seems to be
> unnecessary. Positive max_rx_mempools in dev_info is sufficient to
> indicate that the capability is support and positive number of
> mempools in Rx configuration is sufficient to request it.
> - Add helper patch to factor out Rx mempool check to be shared
> for single mempool, buffer split and multiple mempools case.
> - Refine check for a way to provide Rx buffers to be one and only one.
> Either single mempool, or buffer split, or multi mempool.
> - Drop feature advertisement in net/cnxk patch since there is no
> such feature defined yet. I have no strong opinion if a new feature
> is required or not.
> v6:
> - Updated release notes, release_22_11.rst.
> v5:
> - Declared memory pools as struct rte_mempool **rx_mempools rather than
> as struct rte_mempool *mp.
> - Added the feature in release notes.
> - Updated conditions and strings as per review comments.
> v4:
> - Renamed Offload capability name from RTE_ETH_RX_OFFLOAD_BUFFER_SORT
> to RTE_ETH_RX_OFFLOAD_MUL_MEMPOOL.
> - In struct rte_eth_rxconf, defined new pointer, which holds array of
> type struct rte_eth_rx_mempool(memory pools). This array is used
> by PMD to program multiple mempools.
> v3:
> - Implemented Pool Sort capability as new Rx offload capability,
> RTE_ETH_RX_OFFLOAD_BUFFER_SORT.
> v2:
> - Along with spec changes, uploading testpmd and driver changes.
>
> Andrew Rybchenko (1):
> ethdev: factor out helper function to check Rx mempool
>
> Hanumanth Pothula (3):
> ethdev: support multiple mbuf pools per Rx queue
> net/cnxk: support mulitiple mbuf pools per Rx queue
> app/testpmd: support mulitiple mbuf pools per Rx queue
Applied, except testpmd patch, as recommended by Andrew, thanks.
prev parent reply other threads:[~2022-10-08 20:38 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-12 10:46 [PATCH v1 1/1] ethdev: introduce pool sort capability Hanumanth Pothula
2022-08-12 13:27 ` Morten Brørup
2022-08-12 17:24 ` [PATCH v2 1/3] " Hanumanth Pothula
2022-08-12 17:24 ` [PATCH v2 2/3] app/testpmd: add command line argument 'rxseg-mode' Hanumanth Pothula
2022-08-12 17:24 ` [PATCH v2 3/3] net/cnxk: introduce pool sort capability Hanumanth Pothula
2022-08-23 3:26 ` [PATCH v2 1/3] ethdev: " Ding, Xuan
2022-08-24 15:33 ` Ferruh Yigit
2022-08-30 12:08 ` [EXT] " Hanumanth Reddy Pothula
2022-09-06 12:18 ` Ferruh Yigit
2022-09-07 7:02 ` Hanumanth Reddy Pothula
2022-09-07 11:24 ` Ferruh Yigit
2022-09-07 21:31 ` Hanumanth Reddy Pothula
2022-09-13 9:28 ` Ferruh Yigit
2022-09-13 10:00 ` Hanumanth Reddy Pothula
2022-09-02 7:00 ` [PATCH v3 " Hanumanth Pothula
2022-09-02 7:00 ` [PATCH v3 2/3] app/testpmd: Add support for " Hanumanth Pothula
2022-09-02 7:00 ` [PATCH v3 3/3] net/cnxk: introduce " Hanumanth Pothula
2022-09-13 8:06 ` [PATCH v3 1/3] ethdev: " Andrew Rybchenko
2022-09-13 9:31 ` Ferruh Yigit
2022-09-13 10:41 ` [EXT] " Hanumanth Reddy Pothula
2022-09-15 7:07 ` [PATCH v4 1/3] ethdev: Add support for mulitiple mbuf pools per Rx queue Hanumanth Pothula
2022-09-15 7:07 ` [PATCH v4 2/3] app/testpmd: " Hanumanth Pothula
2022-09-15 7:07 ` [PATCH v4 3/3] net/cnxk: Add support for mulitiple mbuf pools Hanumanth Pothula
2022-09-28 9:43 ` [PATCH v4 1/3] ethdev: Add support for mulitiple mbuf pools per Rx queue Andrew Rybchenko
2022-09-28 11:06 ` Thomas Monjalon
2022-10-06 17:01 ` [PATCH v5 1/3] ethdev: support " Hanumanth Pothula
2022-10-06 17:01 ` [PATCH v5 2/3] net/cnxk: " Hanumanth Pothula
2022-10-06 17:01 ` [PATCH v5 3/3] app/testpmd: " Hanumanth Pothula
2022-10-06 17:29 ` [PATCH v5 1/3] ethdev: " Stephen Hemminger
2022-10-07 14:13 ` Andrew Rybchenko
2022-10-06 17:53 ` [PATCH v6 " Hanumanth Pothula
2022-10-06 17:53 ` [PATCH v6 2/3] net/cnxk: " Hanumanth Pothula
2022-10-06 17:53 ` [PATCH v6 3/3] app/testpmd: " Hanumanth Pothula
2022-10-06 18:14 ` [PATCH v6 1/3] ethdev: " Hanumanth Reddy Pothula
2022-10-07 14:37 ` [PATCH v7 0/4] " Andrew Rybchenko
2022-10-07 14:37 ` [PATCH v7 1/4] ethdev: factor out helper function to check Rx mempool Andrew Rybchenko
2022-10-07 14:37 ` [PATCH v7 2/4] ethdev: support mulitiple mbuf pools per Rx queue Andrew Rybchenko
2022-10-07 16:08 ` Thomas Monjalon
2022-10-07 16:18 ` Stephen Hemminger
2022-10-07 16:20 ` Stephen Hemminger
2022-10-07 16:33 ` Andrew Rybchenko
2022-10-07 17:30 ` Andrew Rybchenko
2022-10-07 14:37 ` [PATCH v7 3/4] net/cnxk: " Andrew Rybchenko
2022-10-07 14:37 ` [PATCH v7 4/4] app/testpmd: " Andrew Rybchenko
2022-10-07 17:29 ` [PATCH v8 0/4] ethdev: " Andrew Rybchenko
2022-10-07 17:29 ` [PATCH v8 1/4] ethdev: factor out helper function to check Rx mempool Andrew Rybchenko
2022-10-07 17:29 ` [PATCH v8 2/4] ethdev: support multiple mbuf pools per Rx queue Andrew Rybchenko
2022-10-07 18:35 ` Thomas Monjalon
2022-10-07 19:45 ` Andrew Rybchenko
2022-10-07 17:29 ` [PATCH v8 3/4] net/cnxk: support mulitiple " Andrew Rybchenko
2022-10-07 17:29 ` [PATCH v8 4/4] app/testpmd: " Andrew Rybchenko
[not found] ` <PH0PR18MB47500560DC1793F68E7312DDCB5F9@PH0PR18MB4750.namprd18.prod.outlook.com>
2022-10-07 19:43 ` [EXT] " Andrew Rybchenko
2022-10-07 19:56 ` Hanumanth Reddy Pothula
2022-10-17 8:48 ` [PATCH v9 1/1] " Hanumanth Pothula
2022-10-21 15:57 ` Singh, Aman Deep
2022-10-24 3:32 ` [EXT] " Hanumanth Reddy Pothula
2022-10-24 4:07 ` [PATCH v10 1/1] app/testpmd: support multiple " Hanumanth Pothula
2022-10-25 1:40 ` [PATCH v11 " Hanumanth Pothula
2022-11-01 14:13 ` Hanumanth Reddy Pothula
2022-11-03 12:15 ` Singh, Aman Deep
2022-11-03 12:36 ` [EXT] " Hanumanth Reddy Pothula
2022-11-03 15:20 ` Singh, Aman Deep
2022-11-04 15:38 ` Hanumanth Reddy Pothula
2022-11-07 5:31 ` [PATCH v12 " Hanumanth Pothula
2022-11-09 8:04 ` Singh, Aman Deep
2022-11-09 10:39 ` Andrew Rybchenko
2022-11-10 6:51 ` Andrew Rybchenko
2022-11-10 8:17 ` [PATCH v13 " Hanumanth Pothula
2022-11-10 9:01 ` Andrew Rybchenko
2022-11-10 9:31 ` [EXT] " Hanumanth Reddy Pothula
2022-11-10 10:16 ` [PATCH v14 " Hanumanth Pothula
2022-11-10 10:47 ` Andrew Rybchenko
2022-11-17 8:43 ` Jiang, YuX
2022-11-17 11:38 ` Hanumanth Reddy Pothula
2022-10-08 20:38 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3499917.LM0AJKV5NW@thomas \
--to=thomas@monjalon.net \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=hpothula@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).