From: Ferruh Yigit <ferruh.yigit@intel.com>
To: David Marchand <david.marchand@6wind.com>, thomas.monjalon@6wind.com
Cc: dev@dpdk.org, jblunck@infradead.org, linville@tuxdriver.com,
declan.doherty@intel.com, zlu@ezchip.com, lsun@ezchip.com,
alejandro.lucero@netronome.com, mtetsuyah@gmail.com,
nicolas.pernas.maradei@emutex.com, harish.patil@qlogic.com,
rasesh.mody@qlogic.com, sony.chacko@qlogic.com,
bruce.richardson@intel.com, huawei.xie@intel.com,
yuanhan.liu@linux.intel.com, jianfeng.tan@intel.com
Subject: Re: [dpdk-dev] [PATCH v2 1/2] net: remove dead driver names
Date: Thu, 24 Nov 2016 11:42:49 +0000 [thread overview]
Message-ID: <34e127bd-1f8c-46ea-f602-1f39cb08b698@intel.com> (raw)
In-Reply-To: <1479751574-5704-1-git-send-email-david.marchand@6wind.com>
On 11/21/2016 6:06 PM, David Marchand wrote:
> Since commit b1fb53a39d88 ("ethdev: remove some PCI specific handling"),
> rte_eth_dev_info_get() relies on dev->data->drv_name to report the driver
> name to caller.
>
> Having the pmds set driver_info->driver_name in the pmds is useless,
> since ethdev overwrites it right after.
> The only thing the pmd must do is:
> - for pci drivers, call rte_eth_copy_pci_info() which then sets
> data->drv_name
> - for vdev drivers, manually set data->drv_name
>
> At this stage, virtio-user does not properly report a driver name (fixed in
> next commit).
>
> Signed-off-by: David Marchand <david.marchand@6wind.com>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Reviewed-by: Jan Blunck <jblunck@infradead.org>
Series applied to dpdk-next-net/master, thanks.
prev parent reply other threads:[~2016-11-24 11:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-10 13:51 [dpdk-dev] [PATCH " David Marchand
2016-11-10 13:51 ` [dpdk-dev] [PATCH 2/2] net: align ethdev and eal " David Marchand
2016-11-10 18:46 ` Ferruh Yigit
2016-11-21 16:31 ` [dpdk-dev] [PATCH 1/2] net: remove dead " Jan Blunck
2016-11-21 18:06 ` [dpdk-dev] [PATCH v2 " David Marchand
2016-11-21 18:06 ` [dpdk-dev] [PATCH v2 2/2] net: align ethdev and eal " David Marchand
2016-11-24 11:42 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34e127bd-1f8c-46ea-f602-1f39cb08b698@intel.com \
--to=ferruh.yigit@intel.com \
--cc=alejandro.lucero@netronome.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@6wind.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=harish.patil@qlogic.com \
--cc=huawei.xie@intel.com \
--cc=jblunck@infradead.org \
--cc=jianfeng.tan@intel.com \
--cc=linville@tuxdriver.com \
--cc=lsun@ezchip.com \
--cc=mtetsuyah@gmail.com \
--cc=nicolas.pernas.maradei@emutex.com \
--cc=rasesh.mody@qlogic.com \
--cc=sony.chacko@qlogic.com \
--cc=thomas.monjalon@6wind.com \
--cc=yuanhan.liu@linux.intel.com \
--cc=zlu@ezchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).