From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "John W. Linville" <linville@tuxdriver.com>,
Declan Doherty <declan.doherty@intel.com>,
Chas Williams <chas3@att.com>,
Gaetan Rivet <gaetan.rivet@6wind.com>,
Tetsuya Mukawa <mtetsuyah@gmail.com>,
Santosh Shukla <santosh.shukla@caviumnetworks.com>,
Jerin Jacob <jerin.jacob@caviumnetworks.com>,
Keith Wiles <keith.wiles@intel.com>,
Maxime Coquelin <maxime.coquelin@redhat.com>,
Tiwei Bie <tiwei.bie@intel.com>,
Zhihong Wang <zhihong.wang@intel.com>,
dev@dpdk.org, stable@dpdk.org,
Vipin Varghese <vipin.varghese@intel.com>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] drivers/net: fix segfault in secondary process
Date: Fri, 20 Jul 2018 11:13:07 +0100 [thread overview]
Message-ID: <34e23691-19f9-5c12-eb73-64e87d2f292a@intel.com> (raw)
In-Reply-To: <20180719093200.6095b52c@xeon-e3>
On 7/19/2018 5:32 PM, Stephen Hemminger wrote:
> On Thu, 19 Jul 2018 17:45:56 +0100
> Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
>> Calling rte_eth_dev_info_get() on secondary process cause a crash
>> because eth_dev->device is not set properly.
>>
>> Fixes: ee27edbe0c10 ("drivers/net: share vdev data to secondary process")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> Good catch.
>
> Maybe eth_dev should do this for the device drivers?
> Better to make device drivers as simple and safe as possible.
Agreed, let me try to create a helper function for this.
>
> There seem to be a lot of bugs related to secondary process model.
> Do we have a test suite for that.
>
next prev parent reply other threads:[~2018-07-20 10:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-19 16:45 [dpdk-stable] " Ferruh Yigit
2018-07-19 16:32 ` [dpdk-stable] [dpdk-dev] " Stephen Hemminger
2018-07-20 10:13 ` Ferruh Yigit [this message]
2018-07-19 22:19 ` Zhang, Qi Z
2018-07-20 12:44 ` [dpdk-stable] [PATCH v2] " Ferruh Yigit
2018-07-20 12:23 ` Thomas Monjalon
2018-07-20 13:36 ` [dpdk-stable] [dpdk-dev] " Ferruh Yigit
2018-07-20 14:54 ` [dpdk-stable] [PATCH v3] " Ferruh Yigit
2018-07-26 12:58 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34e23691-19f9-5c12-eb73-64e87d2f292a@intel.com \
--to=ferruh.yigit@intel.com \
--cc=chas3@att.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=gaetan.rivet@6wind.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=keith.wiles@intel.com \
--cc=linville@tuxdriver.com \
--cc=maxime.coquelin@redhat.com \
--cc=mtetsuyah@gmail.com \
--cc=santosh.shukla@caviumnetworks.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=tiwei.bie@intel.com \
--cc=vipin.varghese@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).