From: Thomas Monjalon <thomas@monjalon.net>
To: Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>
Cc: stable@dpdk.org, "Burakov, Anatoly" <anatoly.burakov@intel.com>,
dev@dpdk.org
Subject: Re: [dpdk-stable] [PATCH v3 1/2] memalloc: do not leave unmapped holes in EAL virtual memory area
Date: Thu, 12 Jul 2018 23:42:19 +0200 [thread overview]
Message-ID: <3545756.MiBi3UpLtl@xps> (raw)
In-Reply-To: <5ab83fb6-47d0-d8ca-9efe-b6ac93f3217f@intel.com>
01/06/2018 17:06, Burakov, Anatoly:
> On 01-Jun-18 1:59 PM, Dariusz Stojaczyk wrote:
> > EAL reserves a huge area in virtual address space
> > to provide virtual address contiguity for e.g.
> > future memory extensions (memory hotplug). During
> > memory hotplug, if the hugepage mmap succeeds but
> > doesn't suffice EAL's requiriments, the EAL would
> > unmap this mapping straight away, leaving a hole in
> > its virtual memory area and making it available
> > to everyone. As EAL still thinks it owns the entire
> > region, it may try to mmap it later with MAP_FIXED,
> > possibly overriding a user's mapping that was made
> > in the meantime.
> >
> > This patch ensures each hole is mapped back by EAL,
> > so that it won't be available to anyone else.
> >
> > Changes from v2:
> > * replaced rte_panic() with a CRIT log.
> > * added "git fixline" tags
> >
> > Changes from v1:
> > * checkpatch fixes
> >
> > Fixes: 582bed1e1d1d ("mem: support mapping hugepages at runtime")
> > Cc: anatoly.burakov@intel.com
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>
> > ---
>
> Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
>
> Thomas, could you please fix the commit message on apply?
Yes
Applied, thanks
prev parent reply other threads:[~2018-07-12 21:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1527860361-162114-1-git-send-email-dariuszx.stojaczyk@intel.com>
2018-06-01 12:59 ` Dariusz Stojaczyk
2018-06-01 12:59 ` [dpdk-stable] [PATCH v3 2/2] memalloc: keep in mind a failed MAP_FIXED mmap may still perform an unmap Dariusz Stojaczyk
2018-06-01 15:07 ` Burakov, Anatoly
2018-06-01 15:06 ` [dpdk-stable] [PATCH v3 1/2] memalloc: do not leave unmapped holes in EAL virtual memory area Burakov, Anatoly
2018-07-12 21:42 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3545756.MiBi3UpLtl@xps \
--to=thomas@monjalon.net \
--cc=anatoly.burakov@intel.com \
--cc=dariuszx.stojaczyk@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).