From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: David Marchand <david.marchand@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 1/2] eal: sort and align options lists
Date: Tue, 03 Feb 2015 09:27:56 +0100 [thread overview]
Message-ID: <3575894.8HcOK8U9Qc@xps13> (raw)
In-Reply-To: <CALwxeUsqHWxP7y3kOfBUHTjXim_TSFwHOkeip9DV+MiEoSUY0Q@mail.gmail.com>
2015-02-03 07:26, David Marchand:
> Two little comments.
>
> On Mon, Feb 2, 2015 at 6:44 PM, Thomas Monjalon <thomas.monjalon@6wind.com>
> wrote:
> > @@ -578,37 +579,36 @@ eal_check_common_options(struct internal_config
> > *internal_cfg)
> > void
> > eal_common_usage(void)
> > {
> > - printf("-c COREMASK -n NUM [-m NB] [-r NUM] [-b <domain:bus:devid.func>]"
> > - "[--proc-type primary|secondary|auto]\n\n"
> > + printf("-c COREMASK|-l CORELIST -n CHANNELS [options]\n\n"
> > "EAL common options:\n"
> > - " -c COREMASK : A hexadecimal bitmask of cores to run on\n"
> > - " -l CORELIST : List of cores to run on\n"
> > - " The argument format is <c1>[-c2][,c3[-c4],...]\n"
> [snip]
> > + " -n NUM Number of memory channels\n"
>
> Not really a problem, but for consistency : here, you are talking about
> NUM, while at first, you wrote -n CHANNELS.
Yes you're right. I changed headline but not the description of this option.
Will do.
> [snip]
> > /* first long only option value must be >= 256, so that we won't
> > * conflict with short options */
> > OPT_LONG_MIN_NUM = 256,
> > -#define OPT_HUGE_DIR "huge-dir"
> > - OPT_HUGE_DIR_NUM = OPT_LONG_MIN_NUM,
> > -#define OPT_MASTER_LCORE "master-lcore"
> > +#define OPT_BASE_VIRTADDR "base-virtaddr"
> > + OPT_BASE_VIRTADDR_NUM,
>
> Why skip the first entry ?
> Afaik, OPT_BASE_VIRTADDR_NUM will be set to 257, is it to avoid having this
> = OPT_LONG_MIN_NUM moved anytime we add a new long option at the top of the
> enum ?
Exactly, yes. I think we don't care what is the first number.
It doesn't deserve a painful assignment.
> The rest looks good to me.
> Acked-by: David Marchand <david.marchand@6wind.com>
Thanks
--
Thomas
next prev parent reply other threads:[~2015-02-03 8:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-29 18:07 [dpdk-dev] [PATCH 0/2] help option Thomas Monjalon
2015-01-29 18:07 ` [dpdk-dev] [PATCH 1/2] eal: sort and align options lists Thomas Monjalon
2015-01-29 18:07 ` [dpdk-dev] [PATCH 2/2] eal: add help option Thomas Monjalon
2015-02-02 17:44 ` [dpdk-dev] [PATCH v2 0/2] " Thomas Monjalon
2015-02-02 17:44 ` [dpdk-dev] [PATCH v2 1/2] eal: sort and align options lists Thomas Monjalon
2015-02-03 6:26 ` David Marchand
2015-02-03 8:27 ` Thomas Monjalon [this message]
[not found] ` <1422899093-20207-3-git-send-email-thomas.monjalon@6wind.com>
2015-02-03 6:33 ` [dpdk-dev] [PATCH v2 2/2] eal: add help option David Marchand
2015-02-03 8:20 ` Thomas Monjalon
2015-02-03 9:07 ` David Marchand
2015-02-12 16:47 ` [dpdk-dev] [PATCH v3 0/2] " Thomas Monjalon
2015-02-12 16:47 ` [dpdk-dev] [PATCH v3 1/2] eal: sort and align options lists Thomas Monjalon
2015-02-12 16:47 ` [dpdk-dev] [PATCH v3 2/2] eal: add help option Thomas Monjalon
2015-02-13 10:50 ` [dpdk-dev] [PATCH v3 0/2] " David Marchand
2015-02-24 11:09 ` Thomas Monjalon
2015-02-13 12:57 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3575894.8HcOK8U9Qc@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=david.marchand@6wind.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).