From: Thomas Monjalon <thomas@monjalon.net>
To: David Hunt <david.hunt@intel.com>
Cc: dev@dpdk.org, anatoly.burakov@intel.com
Subject: Re: [dpdk-dev] [PATCH v3] mk: fix make defconfig on FreeBSD
Date: Mon, 23 Apr 2018 22:56:27 +0200 [thread overview]
Message-ID: <3587843.k4HvfGJhFO@xps> (raw)
In-Reply-To: <20180423130902.183473-1-david.hunt@intel.com>
23/04/2018 15:09, David Hunt:
> On FreeBSD, make defconfig generates the config as
> "defconfig_x86_64-bsdapp-", which does not resolve to any known
> config file.
>
> On FreeBSD, we get amd64 out of "uname -m", which was not handled by
> the list of checks, but which now resolves to x86_64-native.
>
> Then we run '$CC --version', and use grep -o with the list of known
> compilers, and set to either gcc, icc or clang. Grep's '-o' option
> returns the matched word rather than the whole line, making the
> result easier to use.
>
> The remaining code in the patch then takes ${compiler}, the "uname -m"
> output and assembles them all together into a valid freebsd config name,
> i.e. "defconfig_x86_64-native-bsdapp-clang".
>
> v3 fixes:
> Removed the call to $CC outside of the defconfig rule.
> No longer breaks the 'make -R showversion'.
> Simplified working out the compiler name using grep -o.
>
> Fixes: bce6c42c4ad5 ("mk: add sensible default target with defconfig")
>
> Tested-by: Anatoly Burakov <anatoly.burakov@intel.com>
> Signed-off-by: David Hunt <david.hunt@intel.com>
Applied, thanks
prev parent reply other threads:[~2018-04-23 20:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-10 15:08 [dpdk-dev] [PATCH v1] " David Hunt
2018-04-10 15:28 ` Thomas Monjalon
2018-04-10 15:52 ` Hunt, David
2018-04-10 15:30 ` Burakov, Anatoly
2018-04-10 15:44 ` [dpdk-dev] [PATCH v2] " David Hunt
2018-04-10 15:55 ` Burakov, Anatoly
2018-04-22 23:36 ` Thomas Monjalon
2018-04-23 13:09 ` [dpdk-dev] [PATCH v3] " David Hunt
2018-04-23 20:56 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3587843.k4HvfGJhFO@xps \
--to=thomas@monjalon.net \
--cc=anatoly.burakov@intel.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).