From: Kevin Traynor <ktraynor@redhat.com>
To: "Zhang, Qi Z" <qi.z.zhang@intel.com>,
David Marchand <david.marchand@redhat.com>,
"Wang, Jie1X" <jie1x.wang@intel.com>
Cc: "stable@dpdk.org" <stable@dpdk.org>,
"Yuan, DukaiX" <dukaix.yuan@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Yang, SteveX" <stevex.yang@intel.com>,
"Yang, Qiming" <qiming.yang@intel.com>,
"Xing, Beilei" <beilei.xing@intel.com>,
"Zhang, Yuying" <yuying.zhang@intel.com>,
Luca Boccassi <bluca@debian.org>,
"Xueming(Steven) Li" <xuemingl@nvidia.com>
Subject: Re: [PATCH] net/i40e: fix X722 NIC receives jumbo frame packets
Date: Tue, 6 Dec 2022 10:12:21 +0000 [thread overview]
Message-ID: <35c0ca6f-33d9-4554-dd0b-72ef97966922@redhat.com> (raw)
In-Reply-To: <DM4PR11MB59945614514202041CCBA935D71B9@DM4PR11MB5994.namprd11.prod.outlook.com>
On 06/12/2022 00:01, Zhang, Qi Z wrote:
> Hi David:
>
>> -----Original Message-----
>> From: David Marchand <david.marchand@redhat.com>
>> Sent: Monday, December 5, 2022 7:15 PM
>> To: Kevin Traynor <ktraynor@redhat.com>; Zhang, Qi Z
>> <qi.z.zhang@intel.com>
>> Cc: stable@dpdk.org; Yuan, DukaiX <dukaix.yuan@intel.com>; Wang, Jie1X
>> <jie1x.wang@intel.com>; dev@dpdk.org; Yang, SteveX
>> <stevex.yang@intel.com>; Yang, Qiming <qiming.yang@intel.com>; Xing,
>> Beilei <beilei.xing@intel.com>; Zhang, Yuying <yuying.zhang@intel.com>
>> Subject: Re: [PATCH] net/i40e: fix X722 NIC receives jumbo frame packets
>>
>> Hi Kevin, Qi,
>>
>> On Thu, Nov 10, 2022 at 10:48 AM Zhang, Qi Z <qi.z.zhang@intel.com>
>> wrote:
>>>>> Subject: [PATCH] net/i40e: fix X722 NIC receives jumbo frame
>>>>> packets
>>>>>
>>>>> For NIC I40E_10G-10G_BASE_T_X722, when the port is configured with
>>>>> link speed, it cannot receive jumbo frame packets.
>>>>>
>>>>> Because it set maximum frame size failed when starts the port that
>>>>> the port link status is still down.
>>>>>
>>>>> This patch fix the error that starts the port will force set
>>>>> maximum frame
>>>> size.
>>>>>
>>>>> Fixes: 2184f7cdeeaa ("net/i40e: fix max frame size config at port
>>>>> level")
>>>>> Cc: stable@dpdk.org
>>>>>
>>>>> Signed-off-by: Jie Wang <jie1x.wang@intel.com>
>>
>> It seems this fix has been missed in 21.11 (for the reason we discussed with
>> Kevin offlist).
>>
>> Our QE reported that reception of jumbo frames seems broken in the 21.11
>> branch.
>>
>> I can reproduce with a X710 nic: v21.11.0 is fine, but v21.11.1 and
>> v21.11.2 show the following error log.
>> Dec 05 05:41:37 xxx ovs-vswitchd[53585]:
>> ovs|00183|dpdk|ERR|i40e_set_mac_max_frame(): Set max frame size at
>> port level not applicable on link down
>>
>> The log goes away with backporting this current patch.
>> Can this be added to 21.11 queue, and have Intel validate this issue?
>
> Yes, the patch has been verified on X722.
Great, can a test also be added to the Intel LTS release validation for
this?
Looking at the chain of fixes, it appears this issue was present on
multiple 21.11.x and 20.11.x releases.
> As the patch Cc stable, we can assume it will be captured in 21.11.3 by default.
>
No, the original commit where the chain of fixes started was not tagged
with 'Fixes:' so this chain of fixes looked like it was fixing an issue
that originated in 22.03.
It is applied now and will be part of 21.11.3.
thanks,
Kevin.
>>
>> Thanks!
>>
>>
>> --
>> David Marchand
>
prev parent reply other threads:[~2022-12-06 10:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-10 3:45 Jie Wang
2022-11-10 5:59 ` Yuan, DukaiX
2022-11-10 9:47 ` Zhang, Qi Z
2022-12-05 11:15 ` David Marchand
2022-12-05 12:02 ` Kevin Traynor
2022-12-06 0:01 ` Zhang, Qi Z
2022-12-06 10:12 ` Kevin Traynor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35c0ca6f-33d9-4554-dd0b-72ef97966922@redhat.com \
--to=ktraynor@redhat.com \
--cc=beilei.xing@intel.com \
--cc=bluca@debian.org \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dukaix.yuan@intel.com \
--cc=jie1x.wang@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=stable@dpdk.org \
--cc=stevex.yang@intel.com \
--cc=xuemingl@nvidia.com \
--cc=yuying.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).