From: "Hunt, David" <david.hunt@intel.com>
To: Marko Kovacevic <marko.kovacevic@intel.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 2/4] power: clean up of acpi files
Date: Mon, 11 Dec 2017 10:44:53 +0000 [thread overview]
Message-ID: <35d56aa1-3dc6-f6ee-0ab8-5ac02fb6c778@intel.com> (raw)
In-Reply-To: <20171128132203.43181-2-marko.kovacevic@intel.com>
Hi Marko,
On 28/11/2017 1:22 PM, Marko Kovacevic wrote:
> Signed-off-by: Marko Kovacevic <marko.kovacevic@intel.com>
> ---
> lib/librte_power/Makefile | 2 +-
> ...e_power_acpi_cpufreq.c => power_acpi_cpufreq.c} | 32 +++++++++++-----------
> ...e_power_acpi_cpufreq.h => power_acpi_cpufreq.h} | 28 +++++++++----------
> lib/librte_power/rte_power.c | 28 +++++++++----------
> 4 files changed, 45 insertions(+), 45 deletions(-)
> rename lib/librte_power/{rte_power_acpi_cpufreq.c => power_acpi_cpufreq.c} (94%)
> rename lib/librte_power/{rte_power_acpi_cpufreq.h => power_acpi_cpufreq.h} (88%)
>
> diff --git a/lib/librte_power/Makefile b/lib/librte_power/Makefile
> index 1b1491d..bf5a55e 100644
> --- a/lib/librte_power/Makefile
> +++ b/lib/librte_power/Makefile
> @@ -42,7 +42,7 @@ EXPORT_MAP := rte_power_version.map
> LIBABIVER := 1
>
> # all source are stored in SRCS-y
> -SRCS-$(CONFIG_RTE_LIBRTE_POWER) := rte_power.c rte_power_acpi_cpufreq.c
> +SRCS-$(CONFIG_RTE_LIBRTE_POWER) := rte_power.c power_acpi_cpufreq.c
> SRCS-$(CONFIG_RTE_LIBRTE_POWER) += rte_power_kvm_vm.c guest_channel.c
>
> # install this header file
> diff --git a/lib/librte_power/rte_power_acpi_cpufreq.c b/lib/librte_power/power_acpi_cpufreq.c
> similarity index 94%
> rename from lib/librte_power/rte_power_acpi_cpufreq.c
> rename to lib/librte_power/power_acpi_cpufreq.c
--snip--
Could I suggest adding the following to the commit message?
"Rename private header file rte_power_acpi_cpufreq.c to
power_acpi_cpufreq.c. This prevents the private functions from leaking
into the documentation.
Change any private functions from rte_<function_name> to just
<function_name>. Reserve the rte_ for public functions. "
Regards,
Dave.
next prev parent reply other threads:[~2017-12-11 10:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-28 13:22 [dpdk-dev] [PATCH v2 1/4] power: changed unsigned to unsigned int Marko Kovacevic
2017-11-28 13:22 ` [dpdk-dev] [PATCH v2 2/4] power: clean up of acpi files Marko Kovacevic
2017-11-28 14:17 ` Bruce Richardson
2017-11-29 16:17 ` Marko Kovacevic
2017-12-11 10:44 ` Hunt, David [this message]
2017-11-28 13:22 ` [dpdk-dev] [PATCH v2 3/4] power: clean up of kvm files Marko Kovacevic
2017-12-11 10:45 ` Hunt, David
2017-11-28 13:22 ` [dpdk-dev] [PATCH v2 4/4] power: clean up of power common header Marko Kovacevic
2017-12-11 10:48 ` Hunt, David
2017-11-28 14:16 ` [dpdk-dev] [PATCH v2 1/4] power: changed unsigned to unsigned int Bruce Richardson
2017-11-29 16:15 ` Marko Kovacevic
2017-12-11 10:43 ` Hunt, David
2017-12-12 14:03 ` [dpdk-dev] [PATCH v3 " Marko Kovacevic
2017-12-12 14:03 ` [dpdk-dev] [PATCH v3 2/4] power: clean up of power common header Marko Kovacevic
2017-12-12 14:03 ` [dpdk-dev] [PATCH v3 3/4] power: clean up of acpi files Marko Kovacevic
2017-12-12 14:03 ` [dpdk-dev] [PATCH v3 4/4] power: clean up of kvm files Marko Kovacevic
2018-01-11 23:14 ` [dpdk-dev] [PATCH v3 1/4] power: changed unsigned to unsigned int Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35d56aa1-3dc6-f6ee-0ab8-5ac02fb6c778@intel.com \
--to=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=marko.kovacevic@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).