From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Chen Jing D(Mark)" <jing.d.chen@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] fm10k: fix a crash bug when quit from testpmd
Date: Mon, 23 Nov 2015 23:55:05 +0100 [thread overview]
Message-ID: <3695173.dQDnAloRu5@xps13> (raw)
In-Reply-To: <1447304251-4145-1-git-send-email-jing.d.chen@intel.com>
2015-11-12 12:57, Chen Jing D:
> From: "Chen Jing D(Mark)" <jing.d.chen@intel.com>
>
> When the fm10k port is closed, both func tx_queue_clean() and
> fm10k_tx_queue_release_mbufs_vec() will try to release buffer in
> SW ring. The latter func won't do sanity check on those pointers
> and cause crash.
>
> The fix include 2 parts.
> 1. Remove Vector TX buffer release func since it can share the
> release functions with regular TX.
> 2. Add log to print out what actual Rx/Tx func is used.
2 parts mean 2 patches.
[...]
> + if (rx_using_sse)
> + PMD_INIT_LOG(ERR, "Use vector Rx func");
> + else
> + PMD_INIT_LOG(ERR, "Use regular Rx func");
Why using en error log level?
next prev parent reply other threads:[~2015-11-23 22:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-12 4:57 Chen Jing D(Mark)
2015-11-17 12:03 ` Qiu, Michael
2015-11-23 22:55 ` Thomas Monjalon [this message]
2015-11-24 2:20 ` Chen, Jing D
2015-11-24 10:31 ` Thomas Monjalon
2015-11-24 3:10 ` [dpdk-dev] [PATCH v2] " Chen Jing D(Mark)
2015-11-24 10:39 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3695173.dQDnAloRu5@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=jing.d.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).